Skip to content

Refactor draft order sync flows#1384

Open
pbennett1-godaddy wants to merge 29 commits into
mainfrom
refactor-draft-order-sync-flows
Open

Refactor draft order sync flows#1384
pbennett1-godaddy wants to merge 29 commits into
mainfrom
refactor-draft-order-sync-flows

Conversation

@pbennett1-godaddy
Copy link
Copy Markdown
Collaborator

@pbennett1-godaddy pbennett1-godaddy commented Jun 3, 2026

Summary

Refactors the React checkout draft-order synchronization flow to make checkout state updates more reliable before payment confirmation.

This branch centralizes draft-order sync behavior, reduces duplicate order mutations, improves recovery/error handling when syncs fail, and ensures payment flows flush pending draft-order changes
before attempting checkout confirmation. It also expands checkout test coverage across validation, shipping, pickup, totals, tips, discounts, payment methods, redirects, hydration, tracking, and error
states.

Changeset

  • Changeset added (docs)

Added:

  • .changeset/quiet-checkouts-sync.md
    • Patch release for @godaddy/react

Test Plan

  • Ran TypeScript validation:

    pnpm --filter @godaddy/react typecheck                                                                                                                                                                
                                                                                                                                                                                                          
- [x] Added and updated checkout test coverage for:                                                                                                                                                       
    - Draft order sync provider behavior                                                                                                                                                                  
    - Checkout confirmation blocking while sync is pending                                                                                                                                                
    - Sync failure recovery paths and displayed errors                                                                                                                                                    
    - Shipping method re-application and tax recalculation                                                                                                                                                
    - Free order / free payment transitions                                                                                                                                                               
    - Pickup selection and fulfillment location flows                                                                                                                                                     
    - Billing and address validation behavior                                                                                                                                                             
    - Payment flush behavior before confirmation                                                                                                                                                          
    - Wallet/payment method rendering and gating                                                                                                                                                          
    - Totals, tips, discounts, redirects, hydration, and tracking contracts                                                                                                                               
- [x] Verified the current @godaddy/react TypeScript errors are resolved.

@pbennett1-godaddy
resync order shipping of shipping lines and lineItems fulfillment NONE
d3a4724
@pbennett1-godaddy
fix feedback from PR and add tests
efcd796
@pbennett1-godaddy
show error if sync fails
ae77874
@pbennett1-godaddy
add confirmCheckout blocker
8981bc0
@pbennett1-godaddy
throw actual error
3a00d7d
@pbennett1-godaddy
reuse sync key logic
3322ea5
@pbennett1-godaddy
refactor all update draft order syncs to avoid extra order mutations
4511e19
@pbennett1-godaddy
add recovery paths and errors for failed syncs
6c6ec23
@pbennett1-godaddy
address feedback
4964414
@pbennett1-godaddy
add catch and drain noops
127daa8
@pbennett1-godaddy
minor fixes for payment method selection and address field name
bda5a2c
@pbennett1-godaddy
sync and type fixes
f486550
@pbennett1-godaddy
Merge branch 'main' of https://github.com/godaddy/javascript into ref…
101bf26 
…actor-draft-order-sync-flows

# Conflicts:
#	packages/react/src/components/checkout/payment/utils/use-confirm-checkout.ts
#	packages/react/src/components/checkout/shipping/shipping-method.tsx
@pbennett1-godaddy
add refetchOnWindowFocus for draft order
2c37b1f
@pbennett1-godaddy
fix shipping method tax recalc and resync order on order refresh
2e68c6c
@pbennett1-godaddy
test(react): cover free payment transitions
e9c84a0 
Task: task-4
@pbennett1-godaddy
test(react): cover checkout pure utilities
d04f864 
Task: task-1
@pbennett1-godaddy
test(react): cover address and pickup helpers
7839e22 
Task: task-2
@pbennett1-godaddy
test(react): cover totals line-items and tips edges
8223e7a 
Task: task-10
@pbennett1-godaddy
test(react): cover draft order sync hydration
5708ec3 
Task: task-3
@pbennett1-godaddy
test(react): cover session discount redirect polish
61546f3 
Task: task-12
@pbennett1-godaddy
test(react): add checkout tracking contract coverage
a31bbb5 
Task: task-8
@pbennett1-godaddy
test(react): finalize checkout tracking contract coverage
bb19099 
Task: task-8
@pbennett1-godaddy
add checkout test suite
89148dc
@pbennett1-godaddy
update test readme
81bb278
@pbennett1-godaddy
remove coverage plan
edea6ac
@pbennett1-godaddy
block mutations while confirming checkout and do not override non-ord…
45875c8 
…er backed rhf fields on sync
@pbennett1-godaddy
adjust changeset
4eacf7e
@pbennett1-godaddy pbennett1-godaddy requested a review from a team as a code owner June 3, 2026 15:57
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 3, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 71ec219

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@godaddy/react Patch
nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pbennett1-godaddy