fix: block RCE via module denylist in YAML config loader#5682
fix: block RCE via module denylist in YAML config loader#5682aimenhamzi01-dot wants to merge 7 commits into
Conversation
fix: enable YAML denylist by default in CLI mode
- Add _BLOCKED_MODULES to prevent dangerous module access - Expand _BLOCKED_YAML_KEYS to cover all dynamic code fields - Set _ENFORCE_DENYLIST = True globally Fixes RCE vulnerability via unsafe function resolution in YAML configuration loader (CVE candidate).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @aimenhamzi01-dot , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing tests before we can proceed with the review. |
|
Hi @aimenhamzi01-dot , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing tests before we can proceed with the review. |
Refactor _BLOCKED_MODULES for better readability.
|
Hi @rohityan, I've fixed the formatting issues raised by the pre-commit checks. Could you please approve the workflows to run the tests? Thank you! |
Problem
The
resolve_code_reference()function inconfig_agent_utils.pyuses
importlibandgetattrto resolve arbitrary Python objectsfrom YAML config, allowing RCE via dangerous modules like
os.system.Solution
_BLOCKED_MODULESto block dangerous modules (os, sys,subprocess, etc.) in
resolve_code_reference()_BLOCKED_YAML_KEYSto cover all dynamic code fields_ENFORCE_DENYLIST = TruegloballyTesting
Verified that loading a YAML config with
os.systemasmodel_codenow raises
ValueErrorinstead of executing the command.Security
This fix addresses an RCE vulnerability reported via Google OSS VRP
(Reference: 506632409)