fix(script): skip ignored directories during push#786
fix(script): skip ignored directories during push#786rohan-patnaik wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
🦋 Changeset detectedLatest commit: caf1c33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the file collection process for the 'gws script +push' command by preventing the tool from traversing ignored directories like hidden folders and 'node_modules'. By filtering these paths before recursion, the tool avoids unnecessary work and ensures cleaner output. Additionally, the PR includes minor code cleanup to improve maintainability and adds comprehensive tests to verify the new exclusion logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the gws script +push command to skip hidden directories and the node_modules folder during file collection. Additionally, it refactors the JSON file processing logic using match guards for better readability and includes new test cases to verify that these directories are correctly ignored. I have no feedback to provide as no review comments were present.
Description
gws script +pushshould ignore directories like hidden folders andnode_moduleswhile collecting Apps Script files. Previously, the helper still descended into those directories and only filtered some files after traversal.This PR skips ignored directories before recursion, so
+pushavoids unnecessary traversal and does not collect files from hidden directories. It also includes a small clippy cleanup in the same file so the repo's pre-submit command passes locally.Dry Run Output:
// Not applicable: this changes local file collection before request creation.Checklist:
AGENTS.mdguidelines (no generatedgoogle-*crates).cargo fmt --allto format the code perfectly.cargo clippy -- -D warningsand resolved all warnings.pnpx changeset) to document my changes.Testing
cargo test -qcargo clippy -- -D warnings