test(falcor-socket-datasource): socket.io 2 + 4 compatibility matrix#18
Draft
lmeyerov wants to merge 1 commit into
Draft
test(falcor-socket-datasource): socket.io 2 + 4 compatibility matrix#18lmeyerov wants to merge 1 commit into
lmeyerov wants to merge 1 commit into
Conversation
Run the FalcorPubSubDataSource ⇄ FalcorPubSubDataSink suite over real socket.io servers/clients in three combinations: - socket.io v2 server ⇄ v2 client (status quo, bumped ~2.0 -> ~2.3 to match production) - socket.io v4 server ⇄ v4 client (migration target, via npm aliases socket.io-v4 / socket.io-client-v4 @ 4.8.x) - socket.io v4 server (allowEIO3: true) ⇄ v2 client — the Engine.IO 3 bridge that staged rollouts rely on (server upgrades before clients) The Source/Sink only use on/emit/removeListener + trailing acks + dynamic event names, unchanged across socket.io 2 -> 4, so all combos must behave identically — including get/set/call, streaming, and cancellation (cancel-falcor-operation-<id> round trip). Also: - remove a stray it.only in tests.base.js that masked every suite down to the single streaming-get test (all unmasked tests pass) - close client + server between suites so back-to-back suites on the shared port can't cross-connect, and make teardown wait for the port - FALCOR_SOCKET_TEST_PORT env override (default stays 3000) for local runs where 3000 is taken 240 passing. Part of graphistry/graphistry#3250 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a socket.io 2 ⇄ 4 compatibility matrix to the
falcor-socket-datasourcetest suite, supporting the graphistry/graphistry socket.io 2.3 → 4.x migration (design:plans/viz-modernization/socketio-4-design.md; S1 of the sequencing).What
test/tests.socket.jsnow runs the full FalcorPubSubDataSource ⇄ FalcorPubSubDataSink suite (get/set/call, streaming, andcancel-falcor-operation-<id>cancellation round trip) over real socket.io servers and clients in three combos:socket.io-v4/socket.io-client-v4)allowEIO3: trueThis empirically confirms the design finding that the Source/Sink need zero changes for socket.io 4: they only use
on/emit/removeListener, trailing acks, and dynamic event names — all unchanged in v4.Also
it.onlyintests.base.jsthat was masking every suite down to the single streaming-get test; all unmasked tests pass.FALCOR_SOCKET_TEST_PORTenv override (default remains 3000) for local runs where 3000 is occupied.Verification
FALCOR_SOCKET_TEST_PORT=3300 npm test→ 240 passing, exit 0 (node 22, mocha via babel-register).Part of graphistry/graphistry#3250
🤖 Generated with Claude Code