fastify@5 + apache-arrow@21 compat (drop multipart)#2
Open
lmeyerov wants to merge 1 commit into
Open
Conversation
- addContentTypeParser 'octet-stream' -> 'application/octet-stream' (fastify@5 validates a full MIME via ContentType.isValid; the bare token throws FST_ERR_CTP_INVALID_TYPE). - fastify-plugin metadata -> '5.x'; deps: fastify-plugin ^5, apache-arrow 21.1.0, fastify(dev) ^5, DROP @fastify/multipart. - DROP multipart support: every fastify-arrow consumer in the graphistry stack (gpu-worker/sessions/gpu-router) is application/octet-stream only; nothing posts multipart/form-data to a fastify-arrow endpoint (the one multipart sender, shapeGraphViaForm, targets forge-etl-python). Avoids the @fastify/multipart v6->v9 callback-API rewrite. Boots clean under fastify@5.8.5 + arrow@21 (register + .ready(); reply.stream + request.recordBatches present). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the graphistry fastify-arrow fork boot under fastify@5 (+ apache-arrow@21), for the streamgl fastify 3→5 migration (graphistry monorepo S5).
Changes
addContentTypeParser('octet-stream', …)→'application/octet-stream'— fastify@5 validates a full MIME (ContentType.isValid); the bare token throwsFST_ERR_CTP_INVALID_TYPEat.ready().fastify-pluginmetadata>= 2.x→5.x; deps:fastify-plugin ^5,apache-arrow 21.1.0, devfastify ^5.@fastify/multipart+ thefromMultipart/isMultipartpath). Rationale: every fastify-arrow consumer in the graphistry stack (gpu-worker/sessions/gpu-router) isapplication/octet-streamonly; nothing postsmultipart/form-datato a fastify-arrow endpoint (the one multipart sender,shapeGraphViaForm, targets forge-etl-python). Also avoids the@fastify/multipartv6→v9 callback-API rewrite (request.multipart()→parts()/file()).Validation
Boots clean under fastify@5.8.5 + arrow@21: register +
.ready();reply.stream+request.recordBatchesdecorators present.🤖 Generated with Claude Code