Skip to content

feat: add a release workflow#368

Merged
tomjaguarpaw merged 1 commit intohaskell:masterfrom
MangoIV:mangoiv/release-preparation
May 4, 2026
Merged

feat: add a release workflow#368
tomjaguarpaw merged 1 commit intohaskell:masterfrom
MangoIV:mangoiv/release-preparation

Conversation

@MangoIV
Copy link
Copy Markdown
Contributor

@MangoIV MangoIV commented Apr 29, 2026

Adds a new release workflow. This workflow adds a couple of things

  • runs autoreconf and cabal sdist
  • uploads the sdist as an artifact
  • unpacks the sdist in another container
  • runs configure script there
  • uploads the configure log as artifact and as job summary (e.g. https://github.com/haskell/process/actions/runs/25102571704) for sanity checking
  • documentation on how to use this information
image

@MangoIV MangoIV force-pushed the mangoiv/release-preparation branch 7 times, most recently from a981ddd to b8618df Compare April 29, 2026 10:00
@MangoIV MangoIV marked this pull request as ready for review April 29, 2026 10:06
@MangoIV MangoIV force-pushed the mangoiv/release-preparation branch 3 times, most recently from 637b831 to d6b6498 Compare April 29, 2026 11:55
@MangoIV
Copy link
Copy Markdown
Contributor Author

MangoIV commented Apr 29, 2026

Looks like github actions uploads are broken! yeyyyy

@tomjaguarpaw
Copy link
Copy Markdown
Member

Not sure if this is ready for review, so can you request review when you want one? Thanks.

@MangoIV
Copy link
Copy Markdown
Contributor Author

MangoIV commented May 1, 2026

No, sorry, something is wrong with the action, I don’t know if it’s caused by gh or something I’m doing wrong. I’m gonna have a look. ^^

@MangoIV MangoIV force-pushed the mangoiv/release-preparation branch 2 times, most recently from ccd4e95 to a23cd25 Compare May 4, 2026 12:33
@MangoIV
Copy link
Copy Markdown
Contributor Author

MangoIV commented May 4, 2026

I think this would be ready for review, sorry for the long wait, @tomjaguarpaw

Comment thread README.md Outdated
Comment thread README.md Outdated
@MangoIV MangoIV force-pushed the mangoiv/release-preparation branch 2 times, most recently from b7e327c to 9154a66 Compare May 4, 2026 12:48
Comment thread README.md Outdated
Copy link
Copy Markdown
Member

@tomjaguarpaw tomjaguarpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! The explanation of how to use it could benefit from a little elaboration and clarification. Happy to suggest some wording, but at the moment I don't know what it means.

@MangoIV
Copy link
Copy Markdown
Contributor Author

MangoIV commented May 4, 2026

@tomjaguarpaw is it okay if I add a .editorconfig in the root here as well while I'm on it? I think the consistency in the README and in the Haskell files would benefit from it.

https://editorconfig.org/ is supported by all editors and much less controversial than automatic formatting.

@MangoIV MangoIV force-pushed the mangoiv/release-preparation branch from 9154a66 to e2ea774 Compare May 4, 2026 13:01
@tomjaguarpaw
Copy link
Copy Markdown
Member

is it okay if I add a .editorconfig in the root

Let's do that in a separate PR.

Comment thread .editorconfig Outdated
@MangoIV MangoIV force-pushed the mangoiv/release-preparation branch from e2ea774 to b84e53b Compare May 4, 2026 13:03
@bgamari-positron
Copy link
Copy Markdown

Thank you for doing this, @MangoIV !

@MangoIV MangoIV requested a review from tomjaguarpaw May 4, 2026 13:27
Comment thread README.md Outdated
add a release workflow that generates the configure script to be
uploaded as part of the cabal sdist.

Co-authored-by: Tom Ellis <tom-github@jaguarpaw.co.uk>
@MangoIV MangoIV force-pushed the mangoiv/release-preparation branch from 1f72b4b to cfe4d06 Compare May 4, 2026 13:47
Copy link
Copy Markdown
Member

@tomjaguarpaw tomjaguarpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomjaguarpaw tomjaguarpaw merged commit e27e2e2 into haskell:master May 4, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants