Skip to content

Use PageHeader title on list pages#2345

Open
elizabetdev wants to merge 1 commit into
mainfrom
page-migrate-lists
Open

Use PageHeader title on list pages#2345
elizabetdev wants to merge 1 commit into
mainfrom
page-migrate-lists

Conversation

@elizabetdev
Copy link
Copy Markdown
Contributor

Summary

Recreated from #2283 now that the base PageLayout/PageHeader work has landed on main.

Test plan

  • Open Alerts, Dashboards list, and Saved Searches; confirm titles and layout unchanged aside from header implementation

Made with Cursor

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

🦋 Changeset detected

Latest commit: 943ff28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment May 27, 2026 5:20pm

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 3
  • Production lines changed: 6
  • Branch: page-migrate-lists
  • Author: elizabetdev

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Deep Review

✅ No critical issues found.

This PR is a three-line API migration switching AlertsPage.tsx:361, DashboardsListPage.tsx:187, and SavedSearchesListPage.tsx:132 from the children-based <PageHeader>Title</PageHeader> form to the explicit title prop form. The PageHeader component at packages/app/src/components/PageHeader.tsx:5-21 formally supports both APIs, and the title branch renders the string inside <h1 className={styles.title}> via the toolbar layout — a small but intentional semantic upgrade (the old children form rendered the title as a raw text node inside <header> with no <h1> element). That semantic change is the stated point of the migration, not a regression.

The changeset entry is present and correctly scoped as a patch on @hyperdx/app. Other call sites that still use the children form (TeamPage.tsx:220, SessionsPage.tsx:394) are out of scope and remain valid against the component contract.


Reviewers (4): correctness, testing, maintainability, project-standards.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

E2E Test Results

All tests passed • 190 passed • 3 skipped • 1302s

Status Count
✅ Passed 190
❌ Failed 0
⚠️ Flaky 5
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Aligns Alerts, Dashboards, and Saved Searches with the shared header API.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant