Monthly Flarelists by nicHoch · Pull Request #458 · i4Ds/STIXCore

nicHoch · 2026-03-23T09:31:12Z

No description provided.

samaloney · 2026-03-23T09:54:24Z

+        """Hook called after reading data from FITS. Mixins override and chain via super()."""
+        s = super()
+        if hasattr(s, "on_deserialize"):
+            s.on_deserialize(data)


Hum this is a bit of code smell - it's breaking the inheritance pattern - I'd suggestion implement on the base case and either pass or raise not implemented error

i implemented a hopefully more pythonic flow

Fits de/serialize hook for converting into fits serializeable icrs frame

codecov-commenter · 2026-03-26T08:51:28Z

Codecov Report

❌ Patch coverage is 26.70807% with 236 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.85%. Comparing base (3ae9671) to head (46ad35c).
⚠️ Report is 18 commits behind head on master.

Files with missing lines	Patch %	Lines
stixcore/products/level3/flarelist.py	20.89%	159 Missing ⚠️
stixcore/products/level3/processing.py	24.13%	44 Missing ⚠️
stixcore/processing/pipeline_daily.py	23.52%	13 Missing ⚠️
stixcore/io/FlareListManager.py	14.28%	6 Missing ⚠️
stixcore/ephemeris/manager.py	20.00%	4 Missing ⚠️
stixcore/io/product_processors/fits/processors.py	55.55%	4 Missing ⚠️
stixcore/products/level3/flarelistproduct.py	57.14%	3 Missing ⚠️
stixcore/processing/FLtoFL.py	0.00%	2 Missing ⚠️
stixcore/products/product.py	92.85%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3ae9671) and HEAD (46ad35c). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (3ae9671) HEAD (46ad35c)

2 1

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   72.23%   66.85%   -5.38%     
==========================================
  Files          78       80       +2     
  Lines        8085     9093    +1008     
==========================================
+ Hits         5840     6079     +239     
- Misses       2245     3014     +769

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

samaloney

I still need to check the code out and run it as hard to fully understand from just reading but looks good, left a few minor comments.

samaloney · 2026-03-26T09:08:37Z

    return table_hdu


+def CreateUtcColumn(table, data, colname, description="UTC Time"):


snake case

Suggested change

def CreateUtcColumn(table, data, colname, description="UTC Time"):

def create_utc_column(table, data, colname, description="UTC Time"):

or maybe create_UTC_column not sure what the PEP says for this?

samaloney · 2026-03-26T09:18:23Z

+        CreateUtcColumn(
+            data,
+            [Time(d, format="isot", scale="utc") for d in mt["start_UTC"]],
+            "start_UTC",
+            description="start time of flare",
+        )


data.add_column(Column([Time(d, format="isot", scale="utc") for d in mt["start_UTC"]], name="start_UTC",description="start time of flare")

not sure if the function is need id honest really do much?

samaloney · 2026-03-26T09:21:05Z

        return kwargs["level"] == "L3" and service_type == 0 and service_subtype == 0 and ssid == 8
+
+
+def longest_constant_sequence(state_array):


test for this would be good

samaloney · 2026-03-26T09:21:11Z

+    return max_length, max_start_idx, max_state
+
+
+def calculate_overlap(range1, range2):


test for this would be good

samaloney · 2026-06-08T09:29:57Z

+        solo_sun_hg, sun_solo_lt = spiceypy.spkezr("SOLO", et, "SUN_EARTH_CEQU", "None", "Sun")
+        sun_earth_hee, sun_earth_lt = spiceypy.spkezr("Earth", et, "SOLO_HEE", "None", "Sun")
+
+        return (sun_earth_lt - sun_solo_lt) * u.s


This is in the fits headers not - also is this from sun center or surface?

samaloney · 2026-06-08T09:32:18Z

+        CreateUtcColumn(
+            data,
+            [Time(d, format="isot", scale="utc") for d in mt["start_UTC"]],
+            "start_UTC",
+            description="start time of flare",
+        )


Time(mt["start_UTC"]) does this work?

samaloney · 2026-06-08T09:35:41Z

+            # TODO redo
+            # if f_data_end > (Spice.instance.get_mk_date(meta_kernel_type="flown") - timedelta(hours=24)):
+            #    return TestForProcessingResult.NotSuitable


samaloney · 2026-06-08T10:48:18Z

+                            np.nan * u.km,
+                            np.nan * u.km,
+                            np.nan * u.km,
+                            peak_time,
+                            np.nan * u.km,
+                            np.nan * u.km,
+                            np.nan * u.km,


Why is this a combination of km and time and are these in a a coordinate frame?
Also why is it 3 distances a time and 3 distances?

samaloney · 2026-06-08T10:51:14Z

+            u.Quantity(solo_y),
+            u.Quantity(solo_z),
+            frame=HeliographicStonyhurst(obstime=solo_times),
+            representation_type="cartesian",


did you serialise them as specifically cartesian

Also what about the observer coordinate?

samaloney · 2026-06-08T10:55:07Z

+        super().on_deserialize(data, **kwargs)
+
+    @classmethod
+    def is_visible(cls, coord):


Need to careful about definitions here some of the problems should live on the examine in STIXpy as it depends - some sources can come from the corona

samaloney · 2026-06-08T10:56:04Z



-class FlarelistSDCLocImg(FlarelistSDCLoc, FlarePeekPreviewMixin):
+class FlarelistSDCLocImg(FlarelistSDCLoc, FlarePeakPreviewMixin):


Suggested change

class FlarelistSDCLocImg(FlarelistSDCLoc, FlarePeakPreviewMixin):

class FlareListSDCLoccationImage(FlarelistSDCLoc, FlarePeakPreviewMixin):

samaloney · 2026-06-08T10:56:25Z



-class FlarelistSCLocImg(FlarelistSCLoc, FlarePeekPreviewMixin):
+class FlarelistSCLocImg(FlarelistSCLoc, FlarePeakPreviewMixin):


Suggested change

class FlarelistSCLocImg(FlarelistSCLoc, FlarePeakPreviewMixin):

class FlareListSCLocationImage(FlarelistSCLoc, FlarePeakPreviewMixin):

samaloney reviewed Mar 23, 2026

View reviewed changes

nicHoch added 3 commits March 23, 2026 15:09

mixings in columns

12a643d

skyCoords components as single columns

0b5f6c4

SkyCoord for flarePosition

1e3f10c

Fits de/serialize hook for converting into fits serializeable icrs frame

nicHoch force-pushed the flarelist branch from 699a991 to 1e3f10c Compare March 23, 2026 14:11

change on_deserialize flow

a888dcb

enable soop update

4bbc2e8

samaloney reviewed Mar 26, 2026

View reviewed changes

nicHoch added 2 commits March 27, 2026 14:36

experimental fix for reading aspect burst data

776b721

added time_shift and disc_size

46ad35c

samaloney reviewed Jun 8, 2026

View reviewed changes

		return table_hdu


		def CreateUtcColumn(table, data, colname, description="UTC Time"):

	def CreateUtcColumn(table, data, colname, description="UTC Time"):
	def create_utc_column(table, data, colname, description="UTC Time"):

		return kwargs["level"] == "L3" and service_type == 0 and service_subtype == 0 and ssid == 8


		def longest_constant_sequence(state_array):

		return max_length, max_start_idx, max_state


		def calculate_overlap(range1, range2):



		class FlarelistSDCLocImg(FlarelistSDCLoc, FlarePeekPreviewMixin):
		class FlarelistSDCLocImg(FlarelistSDCLoc, FlarePeakPreviewMixin):

	class FlarelistSDCLocImg(FlarelistSDCLoc, FlarePeakPreviewMixin):
	class FlareListSDCLoccationImage(FlarelistSDCLoc, FlarePeakPreviewMixin):



		class FlarelistSCLocImg(FlarelistSCLoc, FlarePeekPreviewMixin):
		class FlarelistSCLocImg(FlarelistSCLoc, FlarePeakPreviewMixin):

	class FlarelistSCLocImg(FlarelistSCLoc, FlarePeakPreviewMixin):
	class FlareListSCLocationImage(FlarelistSCLoc, FlarePeakPreviewMixin):

Conversation

nicHoch commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

samaloney left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Mar 26, 2026 •

edited

Loading