fix: BFS reports all requested root vertices instead of only the first#2693
Merged
Conversation
When multiple roots are supplied, the C implementation only returns the scalar `root` (always 0/1), which is meaningless. Now we preserve and return all requested root vertices in the result. Also improve documentation for the `root` parameter (multi-root behavior) and clarify return value types for `order`, `parent`, `pred`, and `succ`. Fixes #1639
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 63a486c is merged into main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1639