Add dual CJS/ESM build#326
Open
tomassabol wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds dual CommonJS and ESM support.
Until now, the package has only shipped as CommonJS, which can make modern ESM bundling workflows awkward. In particular, users bundling Lambda handlers to
.mjswith tools like esbuild can hit dynamicrequire()issues, as described in #295.This change keeps the existing CommonJS API working while adding a proper ESM build and package export map.
What Changed
src/and builds published output intodist/cjsanddist/esmwith SWCrequire()andimportlambda-api/lib/utilsWhy
This should make
lambda-apifriendlier for modern Lambda projects using ESM,.mjsentrypoints, or bundlers like esbuild, while remaining backwards compatible for existing CommonJS users.