Move locale to base Styler; fix locale-aware number formatting in PieChart#964
Merged
Conversation
- Move locale field, getLocale(), and setLocale() from AxesChartStyler up to the base Styler class so all chart types (including Pie) can benefit from locale-aware number formatting - PlotContent_Pie now constructs DecimalFormat with DecimalFormatSymbols derived from the styler locale, fixing locale-dependent decimal separators in pie slice labels and tooltips - Remove stale TODO comment from ChartButton Fixes #868 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
localelived only inAxesChartStyler, making it inaccessible toPieStyler(which extendsStylerdirectly). This meant pie slice labels and tooltips always used the system default locale for decimal separators -- no way to override for non-English locales.What changed:
localefield,getLocale(), andsetLocale()moved fromAxesChartStylerup to the baseStylerclass. All chart types now inherit locale support.PlotContent_Pieconstructs itsDecimalFormatusingDecimalFormatSymbolsderived frompieStyler.getLocale(), so labels like percentages and values respect the configured locale.// TODO tie this to the styler propertiescomment fromChartButton(Swing component -- deliberately not styled viaStyler).Users can now do:
...and get comma decimal separators in pie labels.
Closes #868