Feature/mu ed error handling#19
Open
m-messer wants to merge 4 commits into
Open
Conversation
…on in handle_muEd_command Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… or `200` codes, ensuring proper HTTP response for "UNAVAILABLE" status.
m-messer
force-pushed
the
feature/muEd-error-handling
branch
from
42f9184 to
40ab258
Compare
neagualexa
approved these changes
May 27, 2026
| try: | ||
| version_error = check_muEd_version(event) | ||
| if version_error: | ||
| return wrap_muEd_response(version_error, event, 406) |
Collaborator
There was a problem hiding this comment.
are the response status codes somewhere as an enum? like do we need to define them or is there a library that sets the enums?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #17 and #18 to be merged to the main first.
This PR extends the previous implementation by adding the correct error handling.