feat: make negative max_vram control the amount of spare vram#1503
Open
wbruna wants to merge 1 commit into
Open
feat: make negative max_vram control the amount of spare vram#1503wbruna wants to merge 1 commit into
wbruna wants to merge 1 commit into
Conversation
Owner
|
Please update the document. |
-1 still means 1 GiB, but e.g. -0.2 would spare only 0.2 GiB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repurpose the
-1sentinel value to mean "spare this amount of free VRAM".1 GiB can be a lot in certain circumstances: for instance, a small card, or a dedicated one which doesn't need to keep that much free VRAM available. The user could choose a positive value specific for their case, but that would miss the ability to calculate a good value from the available VRAM.
I've kept the documentation and help texts as-is for now to avoid a big diff, but I'll adapt them if this feature is considered useful.
Checklist