Fix if condition with no refinement#210
Open
CatarinaGamboa wants to merge 4 commits intomainfrom
Open
Conversation
rcosta358
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
When the guard condition had no refinement, we used the default of
true.That, however, became a problem after joining ifs (with no else), since we assumed the condition was true.
Now:
We still create new fresh boolean but leave it empty, leaving the verification to the SMT solver.
We also remove the branches that cannot complete normally from the If joining (
return,throw,break,continue).(This can still be improved if Latte was used.)
Example: