fix(ci): resolve feat/fygaro tsconfig TS5095 + spelling allowlist#642
Merged
Conversation
- tsconfig: module was 'Node16' while the extended @react-native config uses moduleResolution 'bundler', which requires an esnext-class module (TS5095). Set module=esnext + moduleResolution=bundler explicitly. - typos: accept the earns quiz-ID misspellings (Aggrement/Governement) as bare words too — they're a backend contract and can't be renamed. Addresses ENG-420. Does not cover Test (ttypescript — see #640) or the i18n drift (needs `yarn update-translations` run locally). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of getting
feat/fygaroCI green. Fixes two of the four failing checks; the other two are out of scope (noted below).Fixes
TS5095) —tsconfig.jsonsetmodule: "Node16", but the extended@react-native/typescript-configusesmoduleResolution: "bundler", which requires an esnext-class module. Setmodule: "esnext"+ explicitmoduleResolution: "bundler"(the standard RN/Metro combo). Addresses ENG-420.Aggrement/Governementwere flagged as bare words (the earns quiz-ID misspellings also appear in i18n strings / generated types). They're a backend contract (matched against server quiz data + sent toquizCompleted), so they can't be renamed — added to thetypos.tomlword allowlist.Out of scope (separate work)
ttypescript) — needs the ts-jest → ts-patch migration, which chore(test): revive jest suite (ttypescript→ts-patch, ts-jest pin, native mocks) #640 is already doing. chore(test): revive jest suite (ttypescript→ts-patch, ts-jest pin, native mocks) #640 is itself blocked on this same tsconfig, so this PR should help unblock it; recommend landing chore(test): revive jest suite (ttypescript→ts-patch, ts-jest pin, native mocks) #640 rather than duplicating it.BankTransfer.*/AccountUpgrade.international*keys are inen.jsonbut missing from the other locales. Fix isyarn update-translations(typesafe-i18n regen) run locally — can't run Node tooling in CI authoring.Note:
Check Codeis a chain (tsc → eslint → check:translations → codegen → graphql-check); this clears thetscgate, but it may surface a later step (esp.check:translations, which is the same i18n drift) until the i18n keys are backfilled.🤖 Generated with Claude Code