[otbn,top] Add Top-level-test for OTBN-KMAC interface#30385
Merged
Conversation
etterli
force-pushed
the
otbn-kmac-tlt
branch
8 times, most recently
from
054df4c to
392a043
Compare
| // Only allow a squeeze if the app allows it. | ||
| logic squeeze_again_allowed; | ||
| assign squeeze_again_allowed = app_cfg.if_type == AppDynamic && app_cfg.session_cfg.en_xof; | ||
| assign squeeze_again_allowed = app_cfg.if_type == AppDynamic && app_cfg.session_cfg.en_xof && |
Contributor
There was a problem hiding this comment.
Nit: add brackets to improve readability of the logic expression
Contributor
Author
There was a problem hiding this comment.
I agree but this commit is not part of this PR. And the PR it belongs to is already merged now. So I won't change it.
thommythomaso
left a comment
thommythomaso
left a comment
Contributor
There was a problem hiding this comment.
Thanks @etterli, I added one small comment regarding the readability of a logic expression.
Signed-off-by: Pascal Etterli <pascal.etterli@lowrisc.org>
etterli
requested review from
pamaury
and removed request for
a team and
pamaury
nasahlpa
reviewed
Jun 25, 2026
nasahlpa
reviewed
Jun 25, 2026
Signed-off-by: Pascal Etterli <pascal.etterli@lowrisc.org>
nasahlpa
approved these changes
Jun 25, 2026
nasahlpa
left a comment
nasahlpa
left a comment
Contributor
There was a problem hiding this comment.
Thanks Pascal, the test looks good to me.
nasahlpa
reviewed
Jun 25, 2026
andrea-caforio
approved these changes
Jun 25, 2026
andrea-caforio
left a comment
andrea-caforio
left a comment
Contributor
There was a problem hiding this comment.
The test looks good to me, I've been using it for two weeks now without problems. I consider ML-DSA to be the real stress test for the interface.
Thanks @etterli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a top level test where OTBN makes use of the KMAC interface. This serves as a smoke test as well as showcase how to use the interface.
Only the last two commits are relevant. This depends on #30384.