Cherry-pick to earlgrey_1.0.0: [manuf] Fix orchestrator subprocess stdout/stderr flakiness#30440
Open
lowrisc-ci[bot] wants to merge 1 commit into
Open
Cherry-pick to earlgrey_1.0.0: [manuf] Fix orchestrator subprocess stdout/stderr flakiness#30440lowrisc-ci[bot] wants to merge 1 commit into
lowrisc-ci[bot] wants to merge 1 commit into
Conversation
We need to wait for the tee outputs to finish, otherwise there may be a final line buffered in stdout/stderr that is not yet written. In unlucky cases, we can try and look for the data on this line and thus encounter flakiness. This becomes much more likely under heavy processing load, when many tests are running in parallel. Signed-off-by: Alex Jones <alex.jones@lowrisc.org> (cherry picked from commit 3951374)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #29863 to branch
earlgrey_1.0.0.