[otbn] Add otbn_kmac_if to otbn fusecore#30449
Open
victornwaliLowRISC wants to merge 1 commit into
Open
Conversation
Signed-off-by: Victor Nwali <victor.nwali@lowrisc.org>
Contributor
|
Thanks for the PR. I think the description of the PR lacks a bit of context. Could you add a note that explains why this change is needed? |
Contributor
Author
Hi @KinzaQamar , sure I have updated the original PR comment now |
Contributor
|
@victornwaliLowRISC: I think you have updated the github pull request, but not the commit. Once a commit has merged, the pull request isn't really part of the chain any more. Would you mind moving the explanation to the commit message? |
rswarbrick
approved these changes
Jun 22, 2026
rswarbrick
left a comment
rswarbrick
left a comment
Contributor
There was a problem hiding this comment.
It would be nice to tweak the commit message to explain what's going on but, once that's done, this looks like the right change to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added otbn_kmac_if to otbn fusecore.
This change is required for importing the kmac package for the incoming application interface between OTBN and KMAC. Currently the formal DV tool fails at the RTL file elaboration stage without the inclusion of these files to fusesoc
Signed-off-by: Victor Nwali victor.nwali@lowrisc.org