[vendor] PULP debug module patch cleanup#30480
Open
marnovandermaas wants to merge 1 commit into
Open
Conversation
Move RomBaseAddr and RomEndAddr definitions to the patch that actually uses them. This commit also removes the patch numbers inside the subject because this will get out-dated when new patches are added (as has happened with the addition of the eighth patch. Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
Contributor
There was a problem hiding this comment.
I don't see any technical issue with this change. Some of the additions in patch 0002 confused me at first, until I realised that they were just context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move RomBaseAddr and RomEndAddr definitions to the patch that actually uses them. This commit also removes the patch numbers inside the subject because this will get out-dated when new patches are added (as has happened with the addition of the eighth patch.