Skip to content

Wrap toolbar items with MacosToolbarPassthrough#579

Merged
GroovinChip merged 2 commits into
macosui:devfrom
cbenhagen:toolbar_passthrough
Oct 13, 2025
Merged

Wrap toolbar items with MacosToolbarPassthrough#579
GroovinChip merged 2 commits into
macosui:devfrom
cbenhagen:toolbar_passthrough

Conversation

@cbenhagen

Copy link
Copy Markdown
Contributor

Wrap toolbar items with MacosToolbarPassthrough to prevent window move or resize when interacting with toolbar items.

Pre-launch Checklist

  • I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
  • I have added/updated relevant documentation
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could (only the ones affecting my changes)

@cbenhagen

Copy link
Copy Markdown
Contributor Author

@Adrian-Samoticha / @GroovinChip failing checks seem unrelated to this PR.

@Adrian-Samoticha

Copy link
Copy Markdown
Member

@Adrian-Samoticha / @GroovinChip failing checks seem unrelated to this PR.

Yeah, I believe we’ve been failing them for a while now. Thanks for the PR; we’ll review it soon!

@GroovinChip GroovinChip left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but there's some housekeeping that needs to happen on main before it can be merged. I'll try to get to in on Monday.

@GroovinChip

Copy link
Copy Markdown
Collaborator

@cbenhagen In the meantime, could you please post a screenshot or gif of the change in action? Thanks.

@cbenhagen

Copy link
Copy Markdown
Contributor Author

Hard to show in a gif. Without this change the window will maximize if you double click a toolbar item.

@GroovinChip

Copy link
Copy Markdown
Collaborator

@cbenhagen housekeeping has been completed. Please merge the latest changes from dev into your branch and we can move this forward.

@cbenhagen cbenhagen force-pushed the toolbar_passthrough branch from e5d1bb3 to eeda9b5 Compare October 13, 2025 15:46
@cbenhagen

Copy link
Copy Markdown
Contributor Author

@GroovinChip done ;)

@GroovinChip GroovinChip left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but could you please write a test that validates the change so that we can minimize potential regression? Thanks!

@cbenhagen

Copy link
Copy Markdown
Contributor Author

Do you have a good idea how we could test that?

@cbenhagen

Copy link
Copy Markdown
Contributor Author

@GroovinChip I mean we can just test if we find the MacosToolbarPassthrough widget. That's easy enough but to test if it really fixes the maximizing issue would be a challenge.

@cbenhagen

Copy link
Copy Markdown
Contributor Author

@GroovinChip added some tests in 63777d4.

@GroovinChip GroovinChip left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroovinChip GroovinChip merged commit dc4a902 into macosui:dev Oct 13, 2025
2 of 3 checks passed
@cbenhagen cbenhagen deleted the toolbar_passthrough branch October 13, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants