Add patch method using the PATCH HTTP verb#150
Open
jdeniau wants to merge 1 commit into
Open
Conversation
`patch` behaves like `update` (same arguments and UnitOfWork dirty-field handling) but sends a PATCH request instead of PUT. The shared logic is factored into a private `_update` method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
patchmethod toAbstractClient, available on every repository.It behaves exactly like
update(same arguments, same UnitOfWork dirty-field handling — only dirty fields are sent) but issues aPATCHrequest instead ofPUT.Implementation
updateinto a private_update(method, …)helper.update()delegates to_update('PUT', …),patch()delegates to_update('PATCH', …).Tests
allow passing request params in patch— checks request params forwarding and that thePATCHverb is used.patching data with unit of work— checks the dirty-diff works with PATCH (only{ status: 'foo' }is sent, then{}when nothing changed).All
AbstractClienttests andyarn lintpass.Note
The content type stays
application/json(same asupdate). If your API expectsapplication/merge-patch+json, pass it viarequestParams.headers.