fix: support ACCOUNT clause in RESTORE ... FROM PITR#24591
Open
Torrent2002 wants to merge 4 commits into
Open
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
|
7889457 to
dd00ace
Compare
heni02
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #24545.
This PR fixes the grammar inconsistency between
RESTORE ... FROM SNAPSHOTandRESTORE ... FROM PITR.Previously,
RESTORE ACCOUNT <tenant> DATABASE ... TABLE ... FROM SNAPSHOT ...was accepted, but the equivalentFROM PITRforms failed in the parser. This change adds support for theACCOUNTclause in scoped PITR restore statements and keeps the restore privilege checks aligned with the existing snapshot behavior.What changed
RESTORE ACCOUNT <acc> DATABASE <db> FROM PITR ...RESTORE ACCOUNT <acc> DATABASE <db> TABLE <tbl> FROM PITR ...ACCOUNTas cross-account restore at the account restore levelACCOUNTwhen it matches the current tenantTesting
go test ./pkg/sql/parsers/dialect/mysql -run 'TestValid|TestPitrInternal' -count=1test/distributed/cases/pitr/pitr_restore_account_clause.sqlNotes
pkg/frontendtargeted tests were not runnable in this environment because unrelated native dependencies failed to build (for exampleusearch.hwas missing)mo-testersetup