Skip to content

XS⚠️ ◾ Clarify parameter documentation and set default value for enableCorrelationHeaderBackwardCompatibility#866

Open
neilr81 wants to merge 2 commits into
mainfrom
bugfix/enableCorrelationHeaderBackwardCompatibility-default
Open

XS⚠️ ◾ Clarify parameter documentation and set default value for enableCorrelationHeaderBackwardCompatibility#866
neilr81 wants to merge 2 commits into
mainfrom
bugfix/enableCorrelationHeaderBackwardCompatibility-default

Conversation

@neilr81

@neilr81 neilr81 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Updated XML documentation to clarify parameter usage and set a default value for enableCorrelationHeaderBackwardCompatibility.

This path is obsolete if set to true and this allows the setting to be omitted entirely for services which don't use it.

Updated XML documentation to clarify parameter usage and set a default value for enableCorrelationHeaderBackwardCompatibility.

This path is obsolete if set to true and this allows the setting to be omitted entirely for services which don't use it.
Copilot AI review requested due to automatic review settings June 22, 2026 15:15
@neilr81 neilr81 requested a review from a team as a code owner June 22, 2026 15:15
@github-actions

Copy link
Copy Markdown
Contributor

PR Metrics

Thanks for keeping your pull request small.
⚠️ Consider adding additional tests.

Lines
Product Code 2
Test Code -
Subtotal 2
Ignored Code -
Total 2

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions Bot changed the title Clarify parameter documentation and set default value XS⚠️ ◾ Clarify parameter documentation and set default value Jun 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the public UseOmexMiddlewares ASP.NET Core extension API documentation and makes the backward-compatibility switch optional by introducing a default value, allowing services that don’t need legacy correlation support to omit the parameter.

Changes:

  • Clarified the XML documentation for enableCorrelationHeaderBackwardCompatibility.
  • Set enableCorrelationHeaderBackwardCompatibility default to false, making the parameter optional for callers.

Comment thread src/Hosting.Services.Web/ApplicationBuilderExtensions.cs Outdated
@neilr81 neilr81 changed the title XS⚠️ ◾ Clarify parameter documentation and set default value XS⚠️ ◾ Clarify parameter documentation and set default value for enableCorrelationHeaderBackwardCompatibility Jun 22, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 22, 2026 15:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@neilr81 neilr81 enabled auto-merge (squash) June 22, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants