Fix: Validate homepage URL scheme before opening browser (ADO#2982591)#2548
Open
lucygramley wants to merge 1 commit into
Open
Fix: Validate homepage URL scheme before opening browser (ADO#2982591)#2548lucygramley wants to merge 1 commit into
lucygramley wants to merge 1 commit into
Conversation
OpenHomepage() passes registry-supplied homepage URLs directly to VsShellUtilities.OpenBrowser with no scheme validation, allowing UNC paths or protocol-handler URIs (e.g. \\\\attacker\\share) to trigger SMB hash leaks or arbitrary process launch. Add Uri.TryCreate + http/https scheme allow-list in both OpenHomepage() and AddHomepage() to block non-web URLs at display and click time. Fixes ADO#2982591 (NTVS-002, CWE-749) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lucygramley
force-pushed
the
fix/mythos-2982591-homepage-url-validation
branch
from
0b118cd to
0312998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ADO#2982591
Changes
NpmPackageInstallViewModel.cs—OpenHomepage()andCanOpenHomepage()now validate that the URL is a well-formed absolute URI with anhttporhttpsscheme before opening it.NpmWorker.cs—AddHomepage()applies the same validation at data ingestion, so non-http(s) URLs are never stored or displayed as clickable links.Test Plan
Added 23 unit tests in
Nodejs/Tests/HomepageValidationTests/that verify:Run with:
\
cd Nodejs/Tests/HomepageValidationTests
dotnet restore --source https://api.nuget.org/v3/index.json
dotnet test --no-restore
\\
All 23 tests pass.