make sure icon images work in monaco too#11348
Open
srietkerk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Monaco flyout category header rendering so that toolbox categories using image-based icons (e.g., extension-provided icons) display correctly in the Monaco experience, aligning behavior with the Blockly toolbox.
Changes:
- Detect image icons via
pxt.toolbox.isImageIcon(icon)and render them with an<img>tag in the Monaco flyout header. - Build the image URL using
pxt.webConfig.commitCdnUrl+encodeURI(icon)to fetch from the commit CDN. - Add Monaco theme styling for the new image icon element sizing/spacing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webapp/src/monacoFlyout.tsx | Renders category icons as <img> when the icon is an image path, instead of relying on CSS class-based icons. |
| theme/monaco.less | Adds sizing/margin styles for the Monaco flyout header image icon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monaco part of the fix for microsoft/pxt-microbit#6769