Add `max-overload` mode to generate protocol or model `WithResponse` overloads for Java data-plane clients by Copilot · Pull Request #10744 · microsoft/typespec

Copilot · 2026-05-20T07:07:36Z

Review new PR feedback and inspect current generated max-overload outputs
Identify why model-mode WithResponse returns protocol response types
Update generator logic/tests for correct model-mode response typing
Regenerate affected http-client-java generator-test outputs
Run targeted validation for http-client-java generator changes
Commit/push fixes and reply to PR comments with commit hash

…hods Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/aee86c1c-fc77-4e89-93e8-a148c5d49443 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/aee86c1c-fc77-4e89-93e8-a148c5d49443 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

srnagar · 2026-05-20T19:20:27Z

 export interface EmitterOptions {
  license?: License;
  "dev-options"?: DevOptions;
+  "max-overload"?: "protocol" | "model" | "all";


Let's only support protocol or model only for now. Remove support for all.

@copilot address the above comment

Done. I removed support for max-overload: all and now only protocol and model are supported in the Java emitter/generator, with related all-mode logic/tests removed. Addressed in commit 4e1d885.

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/b1794428-b7da-4a7c-bb62-831f79584f2c Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

srnagar · 2026-05-20T19:36:02Z

 export interface EmitterOptions {
  license?: License;
  "dev-options"?: DevOptions;
+  "max-overload"?: "protocol" | "model";


Add a comment that this defaults to protocol if not set.

Added the default behavior note in the emitter option description so max-overload explicitly documents defaulting to protocol when unset. Addressed in commit aef08e9. No UI changes in this PR (screenshot N/A).

srnagar · 2026-05-20T19:40:46Z

+      description:
+        "Selects which max `WithResponse` overloads are generated for data-plane clients.",
+      nullable: true,
+      enum: ["protocol", "model"],


Add a test spec in http-client-generator-test and update the Generate.ps1 script to run with protocol and model config to generate both variants.

Added generator/http-client-generator-test/tsp/max-overload.tsp and updated generator/http-client-generator-test/Generate.ps1 to compile that spec with both max-overload=protocol and max-overload=model variants. Addressed in commit aef08e9. No UI changes in this PR (screenshot N/A).

srnagar · 2026-05-20T21:39:42Z

@copilot address PR feedback

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/1a6bac46-b926-4622-8aa3-564c280f9ce1 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Copilot · 2026-05-20T21:46:55Z

@copilot address PR feedback

Addressed the PR feedback in commit aef08e9: documented the default max-overload behavior and added generator-test spec/script coverage for both protocol and model variants. No UI changes in this PR (screenshot N/A).

srnagar · 2026-05-20T21:59:13Z

+      "npx --no tsp compile $tspFile $tspOptions --option ""@typespec/http-client-java.max-overload=protocol"" --option ""@typespec/http-client-java.namespace=tsptest.maxoverload.protocol"" $tspTrace",
+      "npx --no tsp compile $tspFile $tspOptions --option ""@typespec/http-client-java.max-overload=model"" --option ""@typespec/http-client-java.namespace=tsptest.maxoverload.model"" $tspTrace"


@copilot run this script and include the generated code in the PR.

Ran generator/http-client-generator-test/Generate.ps1 and checked in the generated max-overload outputs for both protocol and model variants in commit 1e67e30. No UI changes in this PR (screenshot N/A).

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/811619f6-9770-4590-bbff-a632e211d8a6 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Copilot · 2026-05-20T22:18:53Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

archive.eclipse.org
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.15/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.15/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.15 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.15/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/typespec/typespec/packages/http-client-java/generator org.codehaus.plexus.classworlds.launcher.Launcher clean install --define spotless:skip --no-transfer-progress -T 1C -f ./generator/pom.xml -output/10512924rimraf ./dist ./temp ./emitter/temp ./generator/target/emitter.jar (dns block)
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.15/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.15/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.15 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.15/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/typespec/typespec/packages/http-client-java/generator org.codehaus.plexus.classworlds.launcher.Launcher clean install --define spotless:skip --no-transfer-progress -T 1C -f ./generator/pom.xml n t/837677330 --trhttp-client-java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

srnagar · 2026-05-21T07:16:23Z

+     */
+    @Generated
+    @ServiceMethod(returns = ReturnType.SINGLE)
+    public Response<BinaryData> createWidgetWithResponse(BinaryData body, RequestOptions requestOptions) {


@copilot This should have returned Response<Widget> when max-overload: model is used.

Updated this in commit fb1565f so the model max-overload sync method now returns Response<Widget>. No UI changes in this PR (screenshot N/A).

srnagar · 2026-05-21T07:16:45Z

+     */
+    @Generated
+    @ServiceMethod(returns = ReturnType.SINGLE)
+    public Mono<Response<BinaryData>> createWidgetWithResponse(BinaryData body, RequestOptions requestOptions) {


@copilot This should have returned Mono<Response<Widget>> when max-overload: model is used.

Updated this in commit fb1565f so the model max-overload async method now returns Mono<Response<Widget>>. No UI changes in this PR (screenshot N/A).

…ponse Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/48392fa5-7032-4b09-bc91-47f9a7453ac8 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Initial plan

6297adb

Copilot AI assigned Copilot and srnagar May 20, 2026

Copilot started work on behalf of srnagar May 20, 2026 07:07 View session

Copilot AI linked an issue May 20, 2026 that may be closed by this pull request

Feature Request: Option to generate max overloads (WithResponse methods) with models #10742

Open

3 tasks

feat(java): add max-overload mode for model/protocol WithResponse met…

3c13ebe

…hods Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/aee86c1c-fc77-4e89-93e8-a148c5d49443 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

microsoft-github-policy-service Bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label May 20, 2026

refactor(java): finalize max-overload generation updates

32b1305

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/aee86c1c-fc77-4e89-93e8-a148c5d49443 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add option to generate max overloads with models~~ Add max-overload mode to generate protocol/model WithResponse overloads for Java data-plane clients May 20, 2026

Copilot finished work on behalf of srnagar May 20, 2026 07:30

Copilot AI requested a review from srnagar May 20, 2026 07:30

srnagar reviewed May 20, 2026

View reviewed changes

Copilot started work on behalf of srnagar May 20, 2026 19:21 View session

fix(java): remove max-overload all mode support

4e1d885

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/b1794428-b7da-4a7c-bb62-831f79584f2c Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Copilot AI changed the title ~~Add max-overload mode to generate protocol/model WithResponse overloads for Java data-plane clients~~ Add max-overload mode to generate protocol or model WithResponse overloads for Java data-plane clients May 20, 2026

Copilot finished work on behalf of srnagar May 20, 2026 19:28

Copilot AI requested a review from srnagar May 20, 2026 19:28

srnagar reviewed May 20, 2026

View reviewed changes

Copilot started work on behalf of srnagar May 20, 2026 21:39 View session

test(java): add max-overload protocol and model generator spec

aef08e9

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/1a6bac46-b926-4622-8aa3-564c280f9ce1 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Copilot finished work on behalf of srnagar May 20, 2026 21:47

Copilot AI requested a review from srnagar May 20, 2026 21:47

srnagar reviewed May 20, 2026

View reviewed changes

Copilot started work on behalf of srnagar May 20, 2026 21:59 View session

test(java): check in generated max-overload protocol and model code

1e67e30

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/811619f6-9770-4590-bbff-a632e211d8a6 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Copilot finished work on behalf of srnagar May 20, 2026 22:19

Copilot AI requested a review from srnagar May 20, 2026 22:19

srnagar reviewed May 21, 2026

View reviewed changes

Copilot started work on behalf of srnagar May 21, 2026 07:17 View session

fix(java): return model response types for max-overload model withres…

fb1565f

…ponse Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/48392fa5-7032-4b09-bc91-47f9a7453ac8 Co-authored-by: srnagar <51379715+srnagar@users.noreply.github.com>

Copilot finished work on behalf of srnagar May 21, 2026 07:43

Copilot AI requested a review from srnagar May 21, 2026 07:43

		"npx --no tsp compile $tspFile $tspOptions --option ""@typespec/http-client-java.max-overload=protocol"" --option ""@typespec/http-client-java.namespace=tsptest.maxoverload.protocol"" $tspTrace",
		"npx --no tsp compile $tspFile $tspOptions --option ""@typespec/http-client-java.max-overload=model"" --option ""@typespec/http-client-java.namespace=tsptest.maxoverload.model"" $tspTrace"

Conversation

Copilot AI commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srnagar May 20, 2026

Choose a reason for hiding this comment

Uh oh!

srnagar May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2026

Choose a reason for hiding this comment

Uh oh!

srnagar May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2026

Choose a reason for hiding this comment

Uh oh!

srnagar May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2026

Choose a reason for hiding this comment

Uh oh!

srnagar commented May 20, 2026

Uh oh!

Copilot AI commented May 20, 2026

Uh oh!

srnagar May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 20, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

srnagar May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 21, 2026

Choose a reason for hiding this comment

Uh oh!

srnagar May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 20, 2026 •

edited

Loading