In-proc certificate pinning validation override#6233
Merged
Conversation
…lude the catalog info, add tests for GP blocking
florelis
reviewed
May 19, 2026
florelis
reviewed
May 19, 2026
yao-msft
reviewed
May 20, 2026
yao-msft
reviewed
May 20, 2026
florelis
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Adds the ability to override the certificate pinning validation with their own handler for in-proc COM callers. In-proc callers can provide a handler delegate on their
PackageCatalogReferenceobject(s) before callingConnectand will receive a callback when winget would execute a certificate pinning validation. If they accept the server connection, the certificate will be cached as it is with the internal check and automatically approved for any future connections.Note that
Connectmay not actually trigger the callback if the/informationfor the catalog is already cached, but you must set the callback before theConnectcall for it to be attached to the connected catalog for future use.The callback can only be set for the MS Store catalog when the group policy
BypassCertificatePinningForMicrosoftStoreis not configured.🔍 Validation
Added a sample CLI caller that provides the user with a prompt to accept or reject the connection. Manual validation of logs and caching behavior.
Added E2E tests for the callback.
Microsoft Reviewers: Open in CodeFlow