Skip to content

fix(GeoSpatialUtil): accommodate stricter pyshp API#2765

Merged
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:pyshp-compat
Jun 8, 2026
Merged

fix(GeoSpatialUtil): accommodate stricter pyshp API#2765
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:pyshp-compat

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Jun 8, 2026

Copy link
Copy Markdown
Member

pyshp 3.0.11 got stricter about its arguments: https://github.com/GeospatialPython/pyshp#3011

@wpbonelli wpbonelli added this to the 3.10.1 milestone Jun 8, 2026
@wpbonelli wpbonelli added bug dependencies Pull requests that update a dependency file labels Jun 8, 2026
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (9bd9e66).
⚠️ Report is 167 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2765      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +17.0%     
===========================================
  Files          644      677      +33     
  Lines       124135   132686    +8551     
===========================================
+ Hits         68947    96262   +27315     
+ Misses       55188    36424   -18764     
Files with missing lines Coverage Δ
flopy/utils/geospatial_utils.py 91.6% <100.0%> (-1.5%) ⬇️

... and 579 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review June 8, 2026 19:02
@wpbonelli wpbonelli merged commit 8a2d055 into modflowpy:develop Jun 8, 2026
20 checks passed
@wpbonelli wpbonelli deleted the pyshp-compat branch June 8, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant