Skip to content

fix(mfdataplist): accept DataFrame with tuple cellid#2767

Merged
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:fix/mfdataplist-dataframe-tupled-cellid
Jun 9, 2026
Merged

fix(mfdataplist): accept DataFrame with tuple cellid#2767
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:fix/mfdataplist-dataframe-tupled-cellid

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

Fix an inconsistency mentioned in #2758. pd.DataFrame with a tuple cellid column was rejected by .set_data() while the equivalent recarray form was accepted. Accept tuple cellid for DataFrame too.

@wpbonelli wpbonelli added this to the 3.10.1 milestone Jun 9, 2026
@wpbonelli wpbonelli added the bug label Jun 9, 2026
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (511cebf).
⚠️ Report is 169 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mf6/data/mfdataplist.py 85.7% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2767      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +17.0%     
===========================================
  Files          644      677      +33     
  Lines       124135   132696    +8561     
===========================================
+ Hits         68947    96277   +27330     
+ Misses       55188    36419   -18769     
Files with missing lines Coverage Δ
flopy/mf6/data/mfdataplist.py 72.0% <85.7%> (-6.9%) ⬇️

... and 579 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review June 9, 2026 01:53
@wpbonelli wpbonelli merged commit 228668c into modflowpy:develop Jun 9, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant