Skip to content

Assorted resampler fixes#841

Open
padenot wants to merge 15 commits into
mozilla:masterfrom
padenot:bug-2029067
Open

Assorted resampler fixes#841
padenot wants to merge 15 commits into
mozilla:masterfrom
padenot:bug-2029067

Conversation

@padenot

@padenot padenot commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

This stems from BMO#2029067 but includes nice things, notably the allocation bits, that could be significant (depending on the input/output rate ratio). Also includes simplifications.

@padenot padenot requested a review from kinetiknz April 20, 2026 14:56
@padenot padenot force-pushed the bug-2029067 branch 2 times, most recently from d16714c to d66522c Compare April 20, 2026 15:22

@kinetiknz kinetiknz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread src/cubeb_resampler.cpp
Comment thread src/cubeb_utils.h Outdated
Comment thread src/cubeb_resampler_internal.h Outdated
@padenot padenot force-pushed the bug-2029067 branch 2 times, most recently from f87d22a to d3ca75f Compare June 11, 2026 12:32
@padenot

padenot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

@kinetiknz Didn't change this technically, but I can't run format w/ clang-format-15 anymore on ubuntu 26.04 so bumped it and format.

padenot added 4 commits June 11, 2026 14:46
Buffer excess input internally and expose input latency/sizing queries.
Update tests for all-consumed input and zero-frame sizing.
@kinetiknz

Copy link
Copy Markdown
Collaborator

LGTM thanks, let's get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants