Code cleanup#33
Open
mingxwa wants to merge 2 commits intongcpp:mainfrom
Open
Conversation
| template <class F> | ||
| struct ptr_traits<proxy<F>> : inapplicable_traits {}; | ||
| template <class T> | ||
| concept pointer_like = (requires { *std::declval<T&>(); } || |
Collaborator
There was a problem hiding this comment.
Is it requires(T& p) { *p; }?
Comment on lines
+638
to
+639
| template <class T> | ||
| concept pointer_like = (requires { *std::declval<T&>(); } || |
Collaborator
There was a problem hiding this comment.
Q: does it work for void*?
Collaborator
There was a problem hiding this comment.
It looks like pointer_like<std::shared_ptr<void>> yields true but pointer_like<void*> is false.
| template <template <class...> class TT, class... Args> | ||
| struct specialization_traits<TT<Args...>, TT> : applicable_traits {}; | ||
| template <class T, template <class...> class TT> | ||
| concept specialization_of = specialization_traits<T, TT>::applicable; |
Collaborator
There was a problem hiding this comment.
specialization_of<std::vector<int>, std::vector> is true,
specialization_of<const std::vector<int>, std::vector> is false.
Is this by-design?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
proxy" in named requirements ProFacade: Removed clause "Pis not a specialization ofproxy". This does not align with the standard wording style.proxy, specified that they won't participate overload resolution ifstd::decay_t<P>is a specialization ofproxy.detail::ptr_traitsintoconcept pointer_likeandconcept specialization_of.requiresclause inswap().<F>frominvoke().proxiableeligibility.