Diagnostics clean-up#34
Open
mingxwa wants to merge 2 commits intongcpp:mainfrom
Open
Conversation
guominrui
approved these changes
May 6, 2026
| @@ -400,13 +400,10 @@ template <class O> | |||
| concept extended_overload = overload_traits<O>::applicable || | |||
| overload_substitution_traits<O>::applicable; | |||
| template <class P, class F, bool IsDirect, class D, class O> | |||
Collaborator
There was a problem hiding this comment.
Is class F still needed?
| @@ -543,28 +531,11 @@ consteval bool is_reflector_well_formed() { | |||
| return false; | |||
| } | |||
| template <class P, class F, bool IsDirect, class R> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
elsebranch ofif constexpr (proxiable<P, F>), the returnedbooldoesn't make any difference. Removed a bunch of redundantverdictvariables.details::facade_traits::diagnose_proxiable()intodiagnose_proxiable_noreturn().details::refl_traitsfor simplicity and reduced diagnostic call stack for reflections.details::refl_metaintoreflection_metato avoid name collision after simplicity.As manually tested, the diagnostics work as expected. No functional changes.