Update USP doc for routing to clusterIPs#2006
Draft
bjee19 wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
documentation
Contributor
Author
|
This PR is blocked on merging until nginx/nginx-gateway-fabric#5280 goes through. |
bjee19
commented
May 28, 2026
| kind: Service | ||
| name: tea | ||
| loadBalancingMethod: "hash consistent" | ||
| hashMethodKey: "$upstream_addr" |
Contributor
Author
There was a problem hiding this comment.
wouldn't apply correctly without this change
Contributor
There was a problem hiding this comment.
what is the error message? Most definitely worked for me
Contributor
There was a problem hiding this comment.
we should update the examples folder in NGF too then
Contributor
Author
There was a problem hiding this comment.
The UpstreamSettingsPolicy "lb-method-hash" is invalid: spec.hashMethodKey: Invalid value: "": spec.hashMethodKey in body should match '^\$[a-z_]+$'
I think for some reason in my terminal atleast, since its not escaped, the $ like causes it to evaluate the variable
bjee19
commented
May 28, 2026
Comment on lines
516
to
+531
| @@ -527,7 +528,7 @@ EOF | |||
| Verify that the `UpstreamSettingsPolicy` is Accepted: | |||
|
|
|||
| ```shell | |||
| kubectl describe upstreamsettingspolicies.gateway.nginx.org upstream-unset-keepAlive | |||
| kubectl describe upstreamsettingspolicies.gateway.nginx.org upstream-unset-keepalive | |||
Contributor
Author
There was a problem hiding this comment.
apparently names need to be all lowercased, so this wasn't working either
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update USP documentation to add section on routing to Service ClusterIP.
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩