Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fairly straightforward. It supports
switchin the DSL compatible with nimble'sswitch. This will be used in implementingmodel$getParam.The use is
switch(expr, IDs, ...)whereexpris the value to switch on, IDs (compile-time) is a vector of integer IDs for the cases, and...gives code for each case in order, in{}if there is more than one line.This is oriented towards C++ and is different from R's switch. There is no return value.
nSwitchfor R execution is also provided, with a bit more care and error handling that in nimble.There is an issue with clunkiness when one wants default IDs (simply a sequence for the number of options in
...), one must enterIDs = NULL. Leaving it blank doesn't work. That may be addressed later as a minor but annoying issue in thematchDefsystem.This has passed tests so I am going through a PR to leave a record but plan to merge.