Skip to content

Agents got killed before collision while shifting#68

Merged
DivineThreepwood merged 3 commits into
devfrom
65-shifting-agents-get-killed-before-wall-collision
Jun 16, 2026
Merged

Agents got killed before collision while shifting#68
DivineThreepwood merged 3 commits into
devfrom
65-shifting-agents-get-killed-before-wall-collision

Conversation

@tommy33790

@tommy33790 tommy33790 commented May 19, 2026

Copy link
Copy Markdown
Contributor

📜 Description

Changes proposed in this pull request:

🔨 Breaking Changes

  • None

✅ Checklist:

  • Created tests which fail without the change (if possible)
  • Extended the documentation (if necessary)

📸 Screenshots

  • None

❓ How to test

  1. Create new strategy
  2. Add basic rules for tonic and shifting
  3. Run many fights using the strategy
  4. Hopefully no agents die by shifting into a wall

@tommy33790 tommy33790 linked an issue May 19, 2026 that may be closed by this pull request

@DivineThreepwood DivineThreepwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good finding, issue was introduced in commit ad77eb6 and the future check already lead to a kill.

@DivineThreepwood DivineThreepwood marked this pull request as draft June 4, 2026 12:48
@DivineThreepwood DivineThreepwood marked this pull request as ready for review June 4, 2026 12:48
@DivineThreepwood DivineThreepwood merged commit 7b54152 into dev Jun 16, 2026
2 checks passed
@DivineThreepwood DivineThreepwood deleted the 65-shifting-agents-get-killed-before-wall-collision branch June 16, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shifting agents get killed before wall collision

3 participants