Skip to content

Added CommitSetRollbackDuration action for Commit Confirmed extension#164

Merged
dplore merged 2 commits into
openconfig:masterfrom
hellt:commit-confirmed-rollback-reset
Feb 23, 2024
Merged

Added CommitSetRollbackDuration action for Commit Confirmed extension#164
dplore merged 2 commits into
openconfig:masterfrom
hellt:commit-confirmed-rollback-reset

Conversation

@hellt

@hellt hellt commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

This is an alternative version to #161.
In this version, a specific action is added to denote the Set Rollback Duration for the Commit Confirmed action.

@hellt

hellt commented Jan 25, 2024

Copy link
Copy Markdown
Contributor Author

@kidiyoor @dplore
Hi gentlemen; I wonder how do we proceed with this one?
I am fine with following the @kidiyoor suggestion and moving on with the separate action (which is the case expressed in this PR)

@kidiyoor

Copy link
Copy Markdown
Contributor

@hellt

hellt commented Jan 26, 2024

Copy link
Copy Markdown
Contributor Author

@dplore

dplore commented Feb 2, 2024

Copy link
Copy Markdown
Member

This is a last call for comments. This is planned to merge on Feb 15, 2024.

dplore
dplore previously approved these changes Feb 2, 2024
@hellt

hellt commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

@dplore @kidiyoor with the recent commit I added generated stubs for Go and Py so that we can add this functionality to openconfig/gnmic client.

@hellt

hellt commented Feb 22, 2024

Copy link
Copy Markdown
Contributor Author

Hi @dplore
The planned merge date was on Feb 15. Is anything left that is gating this?

@dplore dplore merged commit 255e855 into openconfig:master Feb 23, 2024
@dplore

dplore commented Feb 23, 2024

Copy link
Copy Markdown
Member

Hi @dplore The planned merge date was on Feb 15. Is anything left that is gating this?

Thanks for the ping!

@robshakir

Copy link
Copy Markdown
Member

This should have been merged upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants