Skip to content

fix: add MFA carry over to new sidebar#2589

Open
hperl wants to merge 1 commit into
masterfrom
mfa-carry-over-sidebar
Open

fix: add MFA carry over to new sidebar#2589
hperl wants to merge 1 commit into
masterfrom
mfa-carry-over-sidebar

Conversation

@hperl
Copy link
Copy Markdown
Member

@hperl hperl commented May 26, 2026

Summary by CodeRabbit

  • New Features
    • Added support for upstream Multi-Factor Authentication (MFA) in social sign-in providers.

Review Change Stack

Copilot AI review requested due to automatic review settings May 26, 2026 17:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the existing “Upstream MFA carry-over” social sign-in documentation page to the new sidebars-network.ts sidebar so it appears in the OpenID Connect SSO navigation.

Changes:

  • Included kratos/social-signin/upstream-mfa in the “OpenID Connect SSO” sidebar items list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e831fce-52ba-4e3e-824f-682067b085fb

📥 Commits

Reviewing files that changed from the base of the PR and between bbc9069 and 2ad07a4.

📒 Files selected for processing (1)
  • sidebars-network.ts

📝 Walkthrough

Walkthrough

This PR adds the "kratos/social-signin/upstream-mfa" documentation page reference to the Social Sign-in Providers sidebar category in the network configuration file, making the upstream MFA documentation discoverable through the sidebar navigation.

Changes

Documentation Sidebar Navigation Update

Layer / File(s) Summary
Social Sign-in Providers sidebar navigation
sidebars-network.ts
The upstream-mfa doc ID is added to the items list under the Social Sign-in Providers sidebar category in networkSidebar configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • ory/docs#2507: Adds the same upstream-mfa documentation page to another sidebar configuration file, indicating a coordinated documentation navigation expansion across multiple sidebar configurations.

Suggested labels

upstream

Suggested reviewers

  • aeneasr
  • zepatrik
  • piotrmsc
  • vinckr
  • unatasha8

Poem

🐰 A nav path emerges, bright and clear,
Upstream MFA guides users here,
One line added with focused grace,
Docs now shine in their rightful place! 📚✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided; the required template sections including 'Related Issue or Design Document' and checklist are completely missing. Add a pull request description following the template, including the related issue reference (#), checklist items, and any relevant context about the MFA carry over change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: add MFA carry over to new sidebar' accurately describes the main change: adding an MFA-related entry to the sidebar configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mfa-carry-over-sidebar

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@unatasha8 unatasha8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants