fix windows ingest script#1699
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
Changesingest.ps1 Self-Invocation Refactor
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/ingest.ps1`:
- Around line 26-33: The $SCRIPT_CMD variable uses double quotes around the path
which allows PowerShell to re-interpret special characters like $ and backticks
when users copy the command. Additionally, the third fallback uses a relative
path that depends on the current working directory instead of using
$PSScriptRoot for consistency. Wrap the $SCRIPT_PATH variable reference in
single quotes within the $SCRIPT_CMD assignment to prevent interpolation of
special characters, and replace the fallback value from ".\ingest.ps1" with
$PSScriptRoot concatenated with the script filename to ensure a reliable
absolute path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
* fix windows ingest script * use PSScriptRoot join path
fix to show command to see logs, status and stop the script
Summary by CodeRabbit