Land embed-surface on main (in-canvas affordance exports + transparent/faint-ink viewer)#419
Merged
Merged
Conversation
…t-ink viewer support Lets a host mount the editor's real editing experience on a bare <Viewer> without the full <Editor> shell. editor: export Grid, NodeArrowHandles, MoveTool, ToolManager — the selection handles, the kind-owned mover, the build-tool host, and the drafting grid that feeds tools their grid:* pointer events. See the doc comment in index.tsx for how they cooperate with host camera controls and selection. viewer: two opt-in, non-persisted presentation flags (both default off, so the editor and every other consumer are unchanged): - transparentBackground / <Viewer transparent>: emit premultiplied RGBA masked by geometry + outline alpha (outputColorTransform off on that path) so the scene can float on any page background. ACES tone-mapping makes a true-white opaque background impossible, hence transparency. - inkOpacity: override the per-mode ink-edge opacity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the
feat/embed-surfacework ontomain. The branch was never merged, yet private-editor's submodule pins its tip — so private-editor has been running editor code off an unmerged branch. This rebases that single feature commit onto currentmain(the duplicate #416 grab-offset commit is dropped, since main already has it) so the submodule can return to trackingmain.What it adds (4 files, no icon changes)
packages/editor/src/index.tsx— exports the in-canvas affordances:Grid,NodeArrowHandles,MoveTool,ToolManager.packages/viewer/src/components/viewer/{index,post-processing}.tsx+store/use-viewer.ts— transparent-background + faint-ink viewer support (transparentBackground,inkOpacity).These exports are consumed by private-editor's
/lab/portable-editorembed; without them on main, that route fails to compile.Testing
tsc --noEmitclean forpackages/editor./lab/portable-editorroute compiles + serves 200 against this branch (it 500s against plain main).🤖 Generated with Claude Code