Skip to content

Add a simple command line interface#63

Closed
jaimeMF wants to merge 1 commit into
pbs:mainfrom
jaimeMF:cli
Closed

Add a simple command line interface#63
jaimeMF wants to merge 1 commit into
pbs:mainfrom
jaimeMF:cli

Conversation

@jaimeMF
Copy link
Copy Markdown

@jaimeMF jaimeMF commented Mar 7, 2015

Can be run as 'pycaption' or by calling 'python -m pycaption'

Can be run as 'pycaption' or by calling 'python -m pycaption'
@vladiibine
Copy link
Copy Markdown
Contributor

Hi,
Thanks for your contribution. We haven't merged your PR yet because we're currently in the process of restructuring pycaption a little. This will affect any command line clients, because the reader/writers will now support some additional (and important) arguments. Haven't thought of a nice generic way of supporting these arguments yet, so we'll postpone adding a cli to pycaption for the given time.

I use my own (forked) library as a cli for this library at this moment (https://github.com/vladiibine/pycaption-cli), but that is only because as I said, we don't have a better way to integrate the new parameters that will be used in a future version.

@jaimeMF
Copy link
Copy Markdown
Author

jaimeMF commented Apr 21, 2015

Thanks for the comment, I'll take a look when the new version is released.

@OlteanuRares
Copy link
Copy Markdown
Contributor

Closing this PR — it's from 2015 and the code no longer works with Python 3 (args.input.read().decode() crashes on text-mode file objects). The reader/writer APIs have also grown significantly since then with parameters that a CLI would need to expose.

If we add CLI support in the future, it'll be a fresh implementation accounting for current reader/writer options and the modern project structure. Thanks for the original contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants