Skip to content

Support two-digit sidebar thread jumps#2623

Open
svenbuild wants to merge 4 commits into
pingdotgg:mainfrom
svenbuild:sidebar-two-digit-thread-jumps
Open

Support two-digit sidebar thread jumps#2623
svenbuild wants to merge 4 commits into
pingdotgg:mainfrom
svenbuild:sidebar-two-digit-thread-jumps

Conversation

@svenbuild
Copy link
Copy Markdown

@svenbuild svenbuild commented May 9, 2026

Summary

  • Allow sidebar thread jump shortcuts to target visible threads 10-99 by pressing a second digit shortly after the first shortcut.
  • Extend sidebar shortcut hints after Ctrl+9 with labels like Ctrl+10 and Ctrl+15.
  • Keep existing thread.jump.1 through thread.jump.9 keybinding commands unchanged.

Why

This keeps the existing shortcut model but makes it work for longer thread lists without adding new keybinding commands.

Interaction notes

  • Ctrl+1 still jumps to thread 1 after the short timeout.
  • Ctrl+1, then 5 within the timeout jumps to visible thread 15.
  • The second digit is intentionally accepted while the modifier is still held, so users can type a continuous sequence like Ctrl+1, 5 without releasing Ctrl.
  • Sidebar hints now show the synthesized two-digit labels for visible threads after 9.

Verification

  • bun run test src/components/Sidebar.logic.test.ts from apps/web
  • bun run typecheck --filter=@t3tools/web
  • git diff --check

Note

Support two-digit thread jump shortcuts in the sidebar

  • Extends the sidebar keyboard handler to support two-digit thread jumps (threads 10–99): pressing a single-digit jump key sets a pending state and starts a 250ms timer; if a second digit is entered in time, the combined index is used to navigate.
  • Updates buildThreadJumpLabelMap in Sidebar.tsx to generate composite shortcut labels for threads 10–99 based on the first digit's command and the second digit.
  • Pending jump state is cleared on navigation, route changes, and component unmount.
  • Behavioral Change: single-digit thread jumps now navigate after a 250ms delay rather than immediately, to allow a second digit to be entered.

Macroscope summarized 877be96.


Note

Medium Risk
Changes global sidebar keyboard handling to introduce a timed two-digit jump state, which can subtly affect navigation timing and key event interactions across the app.

Overview
Adds support for two-digit sidebar thread jump shortcuts (10–99) by introducing a short-lived “pending first digit” state; if a second digit is typed within 250ms it navigates to the combined index, otherwise it falls back to the original 1–9 jump.

Extends buildThreadJumpLabelMap to synthesize visible hint labels for threads beyond 9 (e.g. Ctrl+1,0Ctrl+9,9), and ensures pending jump state is cleared on navigation, route changes, traversal shortcuts, and unmount.

Reviewed by Cursor Bugbot for commit 877be96. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 902f398e-ee80-4028-82dc-f3d8a10716c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels May 9, 2026
@svenbuild svenbuild marked this pull request as ready for review May 9, 2026 20:03
Comment thread apps/web/src/components/Sidebar.tsx
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 9, 2026

Approvability

Verdict: Needs human review

New user-facing feature adding two-digit keyboard navigation with an unresolved bug report about edge case handling where navigation intent can be silently lost.

You can customize Macroscope's approvability policy. Learn more.

@svenbuild svenbuild force-pushed the sidebar-two-digit-thread-jumps branch from 90fcd63 to 667a308 Compare May 9, 2026 20:14
@svenbuild svenbuild marked this pull request as draft May 9, 2026 20:14
@svenbuild svenbuild force-pushed the sidebar-two-digit-thread-jumps branch from 667a308 to 70800d6 Compare May 9, 2026 20:23
@svenbuild svenbuild marked this pull request as ready for review May 9, 2026 20:25
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70800d6771

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/Sidebar.tsx
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c2dbcee23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/Sidebar.tsx Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c6ea631c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/Sidebar.tsx
@svenbuild svenbuild force-pushed the sidebar-two-digit-thread-jumps branch from 5c6ea63 to 8c4df85 Compare May 11, 2026 17:44
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels May 11, 2026
Comment thread apps/web/src/components/Sidebar.tsx
@svenbuild svenbuild force-pushed the sidebar-two-digit-thread-jumps branch from 8c4df85 to c86187b Compare May 11, 2026 18:04
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels May 11, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c86187bea1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/Sidebar.tsx
Comment thread apps/web/src/components/Sidebar.tsx Outdated
@svenbuild svenbuild force-pushed the sidebar-two-digit-thread-jumps branch from c86187b to f0c795e Compare May 11, 2026 18:18
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0c795e764

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/Sidebar.tsx Outdated
Comment thread apps/web/src/components/Sidebar.tsx Outdated
Comment thread apps/web/src/components/Sidebar.tsx Outdated
@svenbuild svenbuild force-pushed the sidebar-two-digit-thread-jumps branch from f0c795e to 877be96 Compare May 11, 2026 18:29
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 877be96. Configure here.

Comment thread apps/web/src/components/Sidebar.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant