Add API-Throttling Fall-back#5
Merged
Merged
Conversation
* Use a fallback-URI if GitHub doesn't return a valid installation- source * Update the installer arg-list to one that won't get munged if flattened
dwc0011
previously approved these changes
Jun 29, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
dwc0011
approved these changes
Jun 29, 2026
ferricoxide
added a commit
to ferricoxide/git-bash-formula
that referenced
this pull request
Jun 30, 2026
Merged
ferricoxide
added a commit
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As originally implemented, this formula would attempt to fall back to querying the GitHub API for "latest availalbe version" if a
download_urivalue was not specified via Pillar. While this works reasonably-reliably when this formula is the only one resorting to this method, if there are other formulae doing so in the same SaltStack run, the GitHub API's rate-limits may be breached and this formula will fail. This PR adds a "fallback of last resort" parameter in case the GitHub API's rate-limiting results in no usable download URI being returned via the primary fallback logic.