Skip to content

fixed ssl with proxy#259

Open
stnelso2 wants to merge 3 commits into
pusher:masterfrom
stnelso2:fix-proxy-ssl
Open

fixed ssl with proxy#259
stnelso2 wants to merge 3 commits into
pusher:masterfrom
stnelso2:fix-proxy-ssl

Conversation

@stnelso2
Copy link
Copy Markdown

@stnelso2 stnelso2 commented May 7, 2020

Description of the pull request

... Fix bug #99. This is essentially the same code as PR #176, but it updates the code to work with the version of java_websocket by using WebSocketImpl.DEFAULT_WSS_PORT instead of WebSocket.DEFAULT_WSS_PORT.

Why is the change necessary?

... To fix bug #99


CC @pusher/mobile

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #259 into master will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #259      +/-   ##
============================================
- Coverage     75.93%   75.77%   -0.16%     
  Complexity      279      279              
============================================
  Files            33       33              
  Lines          2418     2423       +5     
  Branches        112      113       +1     
============================================
  Hits           1836     1836              
- Misses          527      532       +5     
  Partials         55       55              
Impacted Files Coverage Δ Complexity Δ
...t/connection/websocket/WebSocketClientWrapper.java 42.85% <0.00%> (-7.15%) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b47cc4...6301c82. Read the comment docs.

@sonologico
Copy link
Copy Markdown
Contributor

sonologico commented Oct 21, 2022

Hi. I want to fix the underlying issue (possibly by just merging this), but looking at the current code and the java-websocketclient, I'm not sure this is needed anymore. It seems that setting the proxy and the socketFactory should be enough. Could you confirm that the current code in master is not enough?

EDIT: closed by mistake. Reopened

@sonologico sonologico closed this Oct 21, 2022
@sonologico sonologico reopened this Oct 21, 2022
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.39%. Comparing base (a7d2b30) to head (208d29a).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...t/connection/websocket/WebSocketClientWrapper.java 0.00% 9 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #259      +/-   ##
============================================
- Coverage     74.65%   74.39%   -0.27%     
  Complexity      363      363              
============================================
  Files            48       48              
  Lines          1965     1972       +7     
  Branches        145      146       +1     
============================================
  Hits           1467     1467              
- Misses          433      440       +7     
  Partials         65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants