fixed ssl with proxy#259
Conversation
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
============================================
- Coverage 75.93% 75.77% -0.16%
Complexity 279 279
============================================
Files 33 33
Lines 2418 2423 +5
Branches 112 113 +1
============================================
Hits 1836 1836
- Misses 527 532 +5
Partials 55 55
Continue to review full report at Codecov.
|
|
Hi. I want to fix the underlying issue (possibly by just merging this), but looking at the current code and the java-websocketclient, I'm not sure this is needed anymore. It seems that setting the proxy and the socketFactory should be enough. Could you confirm that the current code in master is not enough? EDIT: closed by mistake. Reopened |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
============================================
- Coverage 74.65% 74.39% -0.27%
Complexity 363 363
============================================
Files 48 48
Lines 1965 1972 +7
Branches 145 146 +1
============================================
Hits 1467 1467
- Misses 433 440 +7
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description of the pull request
... Fix bug #99. This is essentially the same code as PR #176, but it updates the code to work with the version of java_websocket by using WebSocketImpl.DEFAULT_WSS_PORT instead of WebSocket.DEFAULT_WSS_PORT.
Why is the change necessary?
... To fix bug #99
CC @pusher/mobile