gh-148914: Fix memoization of in-band PickleBuffer in the Python implementation#149052
Merged
serhiy-storchaka merged 2 commits intopython:mainfrom May 2, 2026
Merged
Conversation
serhiy-storchaka
added
needs backport to 3.13
…n implementation Previously, identical PickleBuffers did not preserve identity. Also, empty writable PickleBuffer memoized an empty bytearray object in place of b'' which is a singleton in CPython, so the following references to b'' were unpickled as an empty bytearray object.
serhiy-storchaka
force-pushed
the
empty-picklebuffer-memoization
branch
from
d1a37a0 to
b819df5
Compare
picnixz
reviewed
Apr 27, 2026
| with self.subTest(proto=proto, array_type=array_type, s=s, independent=False): | ||
| b = array_type(s) | ||
| p = self.dumps((b, b), proto) | ||
| import pickletools; pickletools.dis(p) |
Member
There was a problem hiding this comment.
I think it's also a debugging relicate :)
| if self.py_version >= (3, 4): | ||
| array_types += [ZeroCopyBytearray] | ||
| for proto in protocols: | ||
| for proto in protocols[5:]: |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
GH-149274 is a backport of this pull request to the 3.14 branch. |
|
GH-149275 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
May 2, 2026
…on implementation (GH-149052) (GH-149274) Previously, identical PickleBuffers did not preserve identity. Also, empty writable PickleBuffer memoized an empty bytearray object in place of b'' which is a singleton in CPython, so the following references to b'' were unpickled as an empty bytearray object. (cherry picked from commit b897356) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
May 2, 2026
…on implementation (GH-149052) (GH-149275) Previously, identical PickleBuffers did not preserve identity. Also, empty writable PickleBuffer memoized an empty bytearray object in place of b'' which is a singleton in CPython, so the following references to b'' were unpickled as an empty bytearray object. (cherry picked from commit b897356) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, identical PickleBuffers did not preserve identity. Also, empty writable PickleBuffer memoized an empty bytearray object in place of b'' which is a singleton in CPython, so the following references to b'' were unpickled as an empty bytearray object.