Skip to content

GH-126910: Make _Py_get_machine_stack_pointer return the actual stack pointer#149103

Open
markshannon wants to merge 4 commits intopython:mainfrom
markshannon:use-real-stack-pointer
Open

GH-126910: Make _Py_get_machine_stack_pointer return the actual stack pointer#149103
markshannon wants to merge 4 commits intopython:mainfrom
markshannon:use-real-stack-pointer

Conversation

@markshannon
Copy link
Copy Markdown
Member

@markshannon markshannon commented Apr 28, 2026

(or something close it), but not the frame pointer

  • Make _Py_ReachedRecursionLimit inline again
  • Remove _Py_MakeRecCheck replacing its use with _Py_ReachedRecursionLimit
  • Move the check for C stack swtiching into _Py_CheckRecursiveCall

This is a rebase of #147945 which was reverted due to a non-reproducable buildbot failure.

…ething close it), but not the frame pointer

* Make _Py_ReachedRecursionLimit inline again
* Remove _Py_MakeRecCheck replacing its use with _Py_ReachedRecursionLimit
* Move the check for C stack swtiching into _Py_CheckRecursiveCall
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented Apr 29, 2026

Documentation build overview

📚 cpython-previews | 🛠️ Build #32465483 | 📁 Comparing 01fe604 against main (d4eee16)

  🔍 Preview build  

6 files changed · ± 6 modified

± Modified

@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2026
@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 01fe604 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149103%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2026
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 6, 2026
@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 98073f5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149103%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 6, 2026
@markshannon
Copy link
Copy Markdown
Member Author

@pablogsal
Can you tell what is going on with the buildbot/AMD64 CentOS9 NoGIL PR buildbot?
The test_python_calls_appear_in_the_stack_if_perf_activated test is failing.
Interstingly py_trampoline_evaluator appears 1000s of times in the test output.
Isn't that supposed to show as the Python function in perf?

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal

Can you tell what is going on with the buildbot/AMD64 CentOS9 NoGIL PR buildbot?

The test_python_calls_appear_in_the_stack_if_perf_activated test is failing.

Interstingly py_trampoline_evaluator appears 1000s of times in the test output.

Isn't that supposed to show as the Python function in perf?

Perf should add the Python function below that one, yes. I need time to investigate I will try to do it this week but I am a bit overwhelmed with pending things. I will try to take a look as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants