Skip to content

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py#149345

Open
skirpichev wants to merge 9 commits intopython:mainfrom
skirpichev:amend-e-format
Open

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py#149345
skirpichev wants to merge 9 commits intopython:mainfrom
skirpichev:amend-e-format

Conversation

@skirpichev
Copy link
Copy Markdown
Member

@skirpichev skirpichev commented May 4, 2026 •
edited
Loading

@skirpichev
pythongh-146238: add missing tests for 'e' type code in test_buffer.py
d00c981 
This amends e79fd60.  I'll not fix this for 'F'/'D' complex types as
they might be removed.
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2026
Closed
@skirpichev skirpichev closed this May 4, 2026
@skirpichev skirpichev deleted the amend-e-format branch May 4, 2026 15:25
@skirpichev skirpichev restored the amend-e-format branch May 5, 2026 02:01
@skirpichev skirpichev reopened this May 5, 2026
@skirpichev skirpichev changed the title gh-146238: add missing tests for 'e' type code in test_buffer.py gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py May 5, 2026
@skirpichev skirpichev requested a review from vstinner May 5, 2026 02:27
@skirpichev
Copy link
Copy Markdown
Member Author

skirpichev commented May 5, 2026

CC @vstinner

@skirpichev

This comment was marked as resolved.

Sign in to view
@read-the-docs-community

This comment was marked as spam.

Sign in to view
vstinner
vstinner reviewed May 5, 2026
View reviewed changes
Comment thread Lib/test/test_buffer.py Outdated
Comment thread Lib/test/test_buffer.py Outdated
Comment thread Lib/test/test_buffer.py
@vstinner

This comment was marked as resolved.

Sign in to view
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 5, 2026

On WASI, ALIGNOF_MAX_ALIGN_T is 16 bytes and struct.calcsize("Zd") is 16 bytes. WASI is a 32-bit platform (sys.maxsize is 2147483647). Maybe we should only test formats up to 4 bytes?

Would it make sense to use MAX_ALIGN = struct.calcsize('P')?

@skirpichev
Copy link
Copy Markdown
Member Author

skirpichev commented May 6, 2026

Would it make sense to use MAX_ALIGN = struct.calcsize('P')?

As you see from the commit history, just removing the 'Zd' type - works. But I would like to use a more generic solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skirpichev @vstinner