gh-100239: specialize mixed int/float inplace binary ops#149413
Open
Wulian233 wants to merge 1 commit intopython:mainfrom
Open
gh-100239: specialize mixed int/float inplace binary ops#149413Wulian233 wants to merge 1 commit intopython:mainfrom
Wulian233 wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Author
|
Should I request @markshannon review? Thank you! |
markshannon
approved these changes
May 5, 2026
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Nice, simple change.
Looks good to me.
Contributor
|
Nice! If performance matters for this case, we can also add tier2 ops that use inplace operations in case the float is uniquely referenced. (for a followup PR though) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.