Avoid widening incompatible ParamSpec constraints#21400
Open
MestreY0d4-Uninter wants to merge 2 commits intopython:masterfrom
Open
Avoid widening incompatible ParamSpec constraints#21400MestreY0d4-Uninter wants to merge 2 commits intopython:masterfrom
MestreY0d4-Uninter wants to merge 2 commits intopython:masterfrom
Conversation
for more information, see https://pre-commit.ci
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/commands/onegadget.py:26: error: Cannot infer function type argument [misc]
+ pwndbg/commands/cpsr.py:18: error: Cannot infer function type argument [misc]
antidote (https://github.com/Finistere/antidote)
+ src/antidote/core/_inject.py:293: error: Cannot infer value of type parameter "_P" of "staticmethod" [misc]
discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/core.py:672: error: Unused "type: ignore" comment [unused-ignore]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #21384.
Summary
This avoids widening incompatible precise
ParamSpeclower-bound constraints toAnywhen solving constraints. In the protocol case from #21384, different protocol members can infer conflicting concrete parameter lists; joining those currently erases the conflict and lets invalid calls through.The PR keeps imprecise
ParamSpecargument constraints on the existing path, and only rejects incompatible preciseParametersconstraints.This addresses the free-function and wrapper-argument paths from the issue. The direct generic self-call form still needs separate handling.
Test Plan
PYTHONPATH=. uv run --no-project --isolated --with-requirements test-requirements.txt python -m pytest -q mypy/test/testcheck.py::TypeCheckSuite::check-parameter-specification.test mypy/test/testsolve.pyPYTHONPATH=. uv run --no-project --isolated --with-requirements test-requirements.txt python -m mypy --config-file mypy_self_check.ini mypy/solve.pygit diff --check