Skip to content

BACKPORT change to install DT overlays via dtbs_install#654

Open
vishwasudupa wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
vishwasudupa:bp/install_dtb
Open

BACKPORT change to install DT overlays via dtbs_install#654
vishwasudupa wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
vishwasudupa:bp/install_dtb

Conversation

@vishwasudupa

@vishwasudupa vishwasudupa commented Jun 4, 2026

Copy link
Copy Markdown

Overlay binaries (.dtbo) are currently only built implicitly as
dependencies of composite firmware images and are therefore absent from the
kernel install output.

Even when final DTBs are produced at build time, some distributions rely on
standalone DTBOs for runtime selection and application by bootloaders or
firmware. Without explicit install targets, DTBOs are not picked up by the
standard dtbs_install flow and therefore cannot be packaged alongside DTBs.

BACKPORT change to add dtb-$(CONFIG_ARCH_QCOM) entries for all DT overlays defined in
this Makefile so they are installed via dtbs_install, matching existing
DTB install behavior.

CRs-Fixed: 4561683

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #654 — validate-patch

PR: #654

Verdict Issues Detailed Report
⚠️ 5 Full report

Final Summary

Commit 1/2 (FROMLIST):

  1. Lore link present: Yes — https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
  2. Lore link matches PR commits: Cannot verify — lore.kernel.org unreachable due to network restrictions
  3. Upstream patch status: Cannot verify — network restricted; FROMLIST prefix indicates patch posted but not yet merged at time of backport
  4. PR present in qcom-next: Not checked — would require kernel tree access (explicitly prohibited in constraints)

Commit 2/2 (QCLINUX):

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #654
Commits: 2 patches (1 FROMLIST + 1 QCLINUX vendor-only)
Verdict: ⚠️ PARTIAL


Commit 1/2: BACKPORT: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install

Upstream commit: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
Cherry-picked from: 7998dbf

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore.kernel.org unreachable (network restricted)
Body preserves rationale Clear explanation of DTBO install problem and solution
Fixes tag present/correct N/A No Fixes tag (not a bugfix)
Authorship preserved Vishwas Udupa vudupa@qti.qualcomm.com consistent
Backport note (if applicable) Cherry-pick note present with source SHA

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds 18 DTBO install targets; pattern consistent

DTBO files added (18):

  • apq8016-sbc-d3-camera-mezzanine.dtbo
  • apq8016-sbc-usb-host.dtbo
  • lemans-evk-camera-csi1-imx577.dtbo
  • lemans-evk-ifp-mezzanine.dtbo
  • monaco-evk-camera-imx577.dtbo
  • monaco-evk-ifp-mezzanine.dtbo
  • talos-el2.dtbo
  • qcs6490-rb3gen2-industrial-mezzanine.dtbo
  • qcs6490-rb3gen2-vision-mezzanine.dtbo
  • monaco-el2.dtbo
  • lemans-el2.dtbo
  • qrb5165-rb5-vision-mezzanine.dtbo
  • sc7180-el2.dtbo
  • sc8280xp-el2.dtbo
  • sdm845-db845c-navigation-mezzanine.dtbo
  • sm8650-hdk-display-card.dtbo
  • talos-evk-lvds-auo,g133han01.dtbo
  • x1-el2.dtbo

Commit 2/2: BACKPORT: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays

Upstream commit: N/A (vendor-only)
Cherry-picked from: abfeee7

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit
Body preserves rationale Clear explanation of camx DTBO install requirement
Fixes tag present/correct N/A No Fixes tag (not a bugfix)
Authorship preserved Vishwas Udupa vudupa@qti.qualcomm.com consistent
Backport note (if applicable) Cherry-pick note present with source SHA

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds 10 camx DTBO install targets; pattern consistent

DTBO files added (10):

  • hamoa-evk-camx.dtbo
  • lemans-evk-camx.dtbo
  • lemans-camx-el2.dtbo
  • monaco-evk-camx.dtbo
  • monaco-camx-el2.dtbo
  • qcs615-ride-camx.dtbo
  • qcs6490-rb3gen2-vision-mezzanine-camx.dtbo
  • qcs8300-ride-camx.dtbo
  • sa8775p-ride-camx.dtbo
  • talos-evk-camx.dtbo

Issues

Commit 1 - Timeline Anomaly:

  • ⚠️ Commit date vs. lore link date mismatch: Commit authored on Fri, 3 Apr 2026 02:17:06 -0700, but lore message-ID indicates posting date of 2026-04-28 12:37:25. This suggests the commit was created ~25 days BEFORE the patch was posted to the mailing list.
  • Impact: This is unusual but not necessarily incorrect. Possible explanations:
    1. Patch was developed internally first, then posted upstream later
    2. Commit date was preserved from an earlier internal version
    3. The cherry-pick source (7998dbf) may have the earlier date
  • Recommendation: Verify the timeline with the author if this matters for tracking purposes.

Network Restriction:

  • ⚠️ Cannot fetch upstream patch from lore.kernel.org to perform byte-for-byte diff comparison due to network restrictions in this environment.
  • Cannot verify upstream acceptance status (merged/pending/rejected).

Verdict

Commit 1 (FROMLIST): Structurally correct with proper BACKPORT: FROMLIST: prefix, Link tag, Signed-off-by, and cherry-pick note. Diff pattern is clean and consistent. Timeline anomaly noted but not blocking. Cannot verify faithfulness to upstream due to network restrictions.

Commit 2 (QCLINUX): Correct vendor-only format with BACKPORT: QCLINUX: prefix, no Link tag (as expected), proper Signed-off-by and cherry-pick note. Diff pattern is clean and extends Commit 1's work to camx-specific overlays.

Overall: Both commits follow proper kernel commit message conventions and backport tagging. Diffs are surgical, focused, and follow consistent patterns. Merge recommended with the caveat that upstream faithfulness of Commit 1 should be verified when network access is available.


Final Summary

Commit 1/2 (FROMLIST):

  1. Lore link present: Yes — https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
  2. Lore link matches PR commits: Cannot verify — lore.kernel.org unreachable due to network restrictions
  3. Upstream patch status: Cannot verify — network restricted; FROMLIST prefix indicates patch posted but not yet merged at time of backport
  4. PR present in qcom-next: Not checked — would require kernel tree access (explicitly prohibited in constraints)

Commit 2/2 (QCLINUX):

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #654 — checker-log-analyzer

PR: #654
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26945595479

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ⏭️ Skipped - no DTBs built
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance 2 compliance violations
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable (BACKPORT commits)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #654 - arm64: dts: qcom: install DT overlays via dtbs_install
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26945595479

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ⏭️ Skipped - no DTBs built
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance 2 compliance violations
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable (BACKPORT commits)

❌ check-patch-compliance

Root cause: Patch compliance checker detected two violations in the commit messages.

Failure details:

Commit 1 (3397b96fc7da):

Checking commit: BACKPORT: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install
Change is different from the one mentioned in Link

Commit 2 (aaa651a84027):

Checking commit: BACKPORT: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays
No 'Link' found in commit message

Analysis:

  1. First commit issue: The patch claims to be a BACKPORT: FROMLIST: from the lore link https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com, but the checker detected that the actual changes in the PR differ from what's at that upstream link. This violates the backport integrity requirement - a BACKPORT/FROMLIST commit must match the upstream patch exactly (or document intentional deviations).

  2. Second commit issue: The commit is tagged as BACKPORT: QCLINUX: but lacks a Link: trailer entirely. QCLINUX patches should reference the internal commit they're backporting from, or if this is original work, the prefix should be different (e.g., just QCLINUX: without BACKPORT:).

Fix:

For commit 1:

  • If the patch truly matches the FROMLIST version, verify the lore link is correct and the checker may have a false positive
  • If changes were intentionally modified during backport, document the delta in the commit message (e.g., "[ Upstream commit abc123 with modifications: ... ]")
  • If this is actually a different patch, update the Link: to point to the correct upstream source

For commit 2:

  • Add a Link: trailer pointing to the original QCLINUX commit being backported (format: Link: <internal-commit-url> or (cherry picked from commit <sha>))
  • OR if this is new work (not a backport), remove the BACKPORT: prefix and use just QCLINUX: instead

Reproduce locally:

cd /path/to/kernel
git fetch origin pull/654/head:pr-654
git checkout pr-654
../kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base-sha> --head aaa651a84027b82053e4bcec0081dc33decb3359

Verdict

2 blockers must be fixed before merge: Both commits violate patch compliance rules. The first commit's changes don't match its claimed upstream source, and the second commit is missing required Link metadata for a BACKPORT-tagged commit.

@vishwasudupa vishwasudupa marked this pull request as ready for review June 8, 2026 09:53

@shashim-quic shashim-quic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BACKPORT: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays

This should be QCLINUX and not BACKPORT.

BACKPORT: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install

This is FROMLIST.

@vishwasudupa

Copy link
Copy Markdown
Author

BACKPORT: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays

This should be QCLINUX and not BACKPORT.

BACKPORT: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install

This is FROMLIST.

Updated in latest patch

@qcomlnxci qcomlnxci requested a review from a team June 17, 2026 06:40
@qlijarvis

Copy link
Copy Markdown

PR #654 — validate-patch

PR: #654

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

Commit 1/2 (FROMLIST):

  1. Lore link present: Yes - https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
  2. Lore link matches PR commits: Cannot verify - network restricted; lore.kernel.org unreachable
  3. Upstream patch status: Unknown - cannot fetch from lore; FROMLIST prefix suggests posted but not yet merged
  4. PR present in qcom-next: Not checked - no kernel tree available per constraints

Commit 2/2 (QCLINUX):

  1. Lore link present: No - QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A - no lore link to compare against
  3. Upstream patch status: N/A - vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked - QCLINUX: vendor-only commit

Technical Analysis

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #654 - arm64: dts: qcom: install DT overlays via dtbs_install
Upstream commit: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
Verdict: ⚠️ PARTIAL


Commit 1/2: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - network restricted; lore.kernel.org unreachable
Body preserves rationale Clear explanation of problem and solution
Fixes tag present/correct N/A Not a bugfix; feature addition
Authorship preserved Author: Vishwas Udupa vudupa@qti.qualcomm.com
Backport note (if applicable) Cherry-pick trailer present: (cherry picked from commit 7998dbf1695da00ef7a54c3fe90328e251400c90)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ⚠️ Cannot verify against upstream - network restricted

Issues

  • Network restriction: Unable to fetch upstream patch from lore.kernel.org to verify diff faithfulness
  • Cherry-pick SHA: Commit 7998dbf1695da00ef7a54c3fe90328e251400c90 referenced but cannot verify if it exists in any upstream tree
  • FROMLIST prefix: Indicates patch is posted upstream but not yet merged; Link tag points to future date (2026-04-28) which suggests this is a forward-looking patch

Commit Message Quality

The commit message follows kernel conventions:

  • Clear subject line describing the change
  • Problem statement explaining why DTBOs are missing from install output
  • Solution description explaining the fix
  • Proper Link: tag to lore.kernel.org
  • Signed-off-by present
  • Cherry-pick trailer included

Commit 2/2: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear explanation of change
Fixes tag present/correct N/A Not a bugfix
Authorship preserved Author: Vishwas Udupa vudupa@qti.qualcomm.com
Backport note (if applicable) Cherry-pick trailer: (cherry picked from commit abfeee71ec2257a591930d301f965151539d1380)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Vendor-specific camx DTBO additions; consistent with commit 1 pattern

Issues

None - vendor-only commit follows expected pattern.


Overall Assessment

Verdict

⚠️ PARTIAL PASS - Commits are well-formed but upstream verification blocked by network restrictions.

Reasoning:

  • Both commits follow proper kernel commit message format
  • FROMLIST commit has proper lore link and cherry-pick trailer
  • QCLINUX commit correctly marked as vendor-only
  • Diff patterns are consistent and logical (adding .dtbo install targets)
  • Cannot verify: Diff faithfulness to upstream due to network restrictions

Recommendation: Merge conditionally - manual verification of lore link required by reviewer with network access.


Final Summary

Commit 1/2 (FROMLIST):

  1. Lore link present: Yes - https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
  2. Lore link matches PR commits: Cannot verify - network restricted; lore.kernel.org unreachable
  3. Upstream patch status: Unknown - cannot fetch from lore; FROMLIST prefix suggests posted but not yet merged
  4. PR present in qcom-next: Not checked - no kernel tree available per constraints

Commit 2/2 (QCLINUX):

  1. Lore link present: No - QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A - no lore link to compare against
  3. Upstream patch status: N/A - vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked - QCLINUX: vendor-only commit

Technical Analysis

Commit 1: FROMLIST patch

Change pattern: Adds 18 .dtbo install targets to arch/arm64/boot/dts/qcom/Makefile

Files affected:

  • apq8016-sbc-d3-camera-mezzanine.dtbo
  • apq8016-sbc-usb-host.dtbo
  • lemans-evk-camera-csi1-imx577.dtbo
  • lemans-evk-ifp-mezzanine.dtbo
  • monaco-evk-camera-imx577.dtbo
  • monaco-evk-ifp-mezzanine.dtbo
  • talos-el2.dtbo
  • qcs6490-rb3gen2-industrial-mezzanine.dtbo
  • qcs6490-rb3gen2-vision-mezzanine.dtbo
  • monaco-el2.dtbo
  • lemans-el2.dtbo
  • qrb5165-rb5-vision-mezzanine.dtbo
  • sc7180-el2.dtbo
  • sc8280xp-el2.dtbo
  • sdm845-db845c-navigation-mezzanine.dtbo
  • sm8650-hdk-display-card.dtbo
  • talos-evk-lvds-auo,g133han01.dtbo
  • x1-el2.dtbo

Pattern: Each .dtbo file already has a composite target (e.g., foo-dtbs := base.dtb overlay.dtbo) and a composite install target (dtb-$(CONFIG_ARCH_QCOM) += foo.dtb). This patch adds standalone .dtbo install targets.

Commit 2: QCLINUX patch

Change pattern: Adds 10 camx-specific .dtbo install targets

Files affected:

  • hamoa-evk-camx.dtbo
  • lemans-evk-camx.dtbo
  • lemans-camx-el2.dtbo
  • monaco-evk-camx.dtbo
  • monaco-camx-el2.dtbo
  • qcs615-ride-camx.dtbo
  • qcs6490-rb3gen2-vision-mezzanine-camx.dtbo
  • qcs8300-ride-camx.dtbo
  • sa8775p-ride-camx.dtbo
  • talos-evk-camx.dtbo

Pattern: Identical to commit 1 - adds standalone .dtbo install targets for Qualcomm-specific camx overlays.


Observations

Strengths

  1. ✅ Consistent commit message format across both commits
  2. ✅ Proper use of FROMLIST vs QCLINUX prefixes
  3. ✅ Cherry-pick trailers present on both commits
  4. ✅ Clear problem/solution description in commit 1
  5. ✅ Logical separation: upstream-bound changes in commit 1, vendor-only in commit 2
  6. ✅ Diff patterns are clean and follow Makefile conventions

Concerns

  1. ⚠️ Cannot verify upstream diff - network restrictions prevent lore.kernel.org access
  2. ⚠️ Future-dated lore link - Link points to 2026-04-28, but current date is 2026-06-17; suggests patch may have been posted after this PR was created (unusual workflow)
  3. ⚠️ Cherry-pick SHAs unverifiable - Cannot confirm commits 7998dbf1695da00ef7a54c3fe90328e251400c90 and abfeee71ec2257a591930d301f965151539d1380 exist in any tree

Recommendations for Reviewer

  1. Manually verify lore link resolves and matches commit 1 diff
  2. Check if cherry-pick SHAs exist in the target integration branch
  3. Verify FROMLIST patch has not yet been merged upstream (check mainline)
  4. Confirm camx overlays in commit 2 are Qualcomm-specific and not upstream-bound

@qlijarvis

Copy link
Copy Markdown

PR #654 — checker-log-analyzer

PR: #654
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27670738660

Checker Result Summary
Checker Result Summary
checkpatch Both commits pass with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ⏭️ Skipped - no DTBs built under head
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance 2 failures: FROMLIST patch differs from upstream link; QCLINUX patch missing required prefix
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #654 - arm64: dts: qcom: install DT overlays via dtbs_install
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27670738660

Checker Result Summary
checkpatch Both commits pass with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ⏭️ Skipped - no DTBs built under head
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance 2 failures: FROMLIST patch differs from upstream link; QCLINUX patch missing required prefix
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: Two distinct compliance violations detected by the check-patch-compliance checker.

Failure details:

Commit 1 (7eec426):

Checking commit: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install
Change is different from the one mentioned in Link

The patch claims to be from the lore link https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com but the actual diff in the PR does not match what was posted to the mailing list. The checker validates that FROMLIST patches are faithful to their upstream source.

Commit 2 (aa95d42):

Checking commit: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays
Commit summary does not start with a required prefix

The commit uses QCLINUX: prefix but the checker expects one of the standard prefixes. For Qualcomm-specific downstream changes that are not intended for upstream, the correct prefix should be one of: FROMGIT:, BACKPORT:, FROMLIST:, UPSTREAM:, or a subsystem-specific prefix like arm64: dts: qcom:.

Fix:

For commit 1 (FROMLIST patch):

  1. Verify the lore link is correct and accessible
  2. Compare the PR patch against the actual upstream patch at the lore link
  3. Either:
    • Update the patch to exactly match the upstream version (if it was modified), OR
    • Update the Link: tag to point to the correct upstream version, OR
    • If this is a modified version of an upstream patch, change the prefix from FROMLIST: to BACKPORT: and document the changes

For commit 2 (QCLINUX patch):

  1. Since this is Qualcomm-specific downstream code (camx overlays), change the subject prefix from QCLINUX: to arm64: dts: qcom: to match kernel subsystem conventions
  2. Alternatively, if this is based on an upstream or mailing list patch, use the appropriate prefix (FROMLIST:, UPSTREAM:, BACKPORT:, FROMGIT:)

Reproduce locally:

cd /path/to/kernel
git fetch origin qcom-6.18.y
git checkout qcom-6.18.y
# Apply your PR commits
bash /path/to/kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base-sha> --head <head-sha>

Verdict

2 blockers must be fixed before merge: FROMLIST patch content mismatch and QCLINUX prefix violation in check-patch-compliance.

@qlijarvis

Copy link
Copy Markdown

PR #654 — validate-patch

PR: #654

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Not provided in agent output
  2. Lore link matches PR commits: Not provided in agent output
  3. Upstream patch status: Not provided in agent output
  4. PR present in qcom-next: Not provided in agent output
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #654
Commits: 2 patches (1 FROMLIST + 1 QCLINUX vendor-only)
Verdict: ⚠️ PARTIAL — Commit 1 cannot be verified against upstream due to network restrictions


Commit 1: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install

Upstream commit: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
Verdict: ⚠️ CANNOT VERIFY — Network access restricted; lore.kernel.org unreachable

Commit Message

Check Status Note
Subject format Proper FROMLIST prefix; follows kernel style
Body structure Clear problem statement and solution rationale
Link tag present Lore link included before Signed-off-by
Authorship preserved Author: Vishwas Udupa vudupa@qti.qualcomm.com
Signed-off-by present Matches author
Backport note N/A Not a backport; FROMLIST indicates pending upstream

Diff Analysis

Aspect Status Notes
File modified arch/arm64/boot/dts/qcom/Makefile
Change count 18 insertions (adds 18 .dtbo install targets)
Change pattern Consistent: adds dtb-$(CONFIG_ARCH_QCOM) += <overlay>.dtbo after composite dtb definitions
Mechanical correctness Each added line follows existing Makefile syntax

Overlays added (18 total):

  • apq8016-sbc-d3-camera-mezzanine.dtbo
  • apq8016-sbc-usb-host.dtbo
  • lemans-evk-camera-csi1-imx577.dtbo
  • lemans-evk-ifp-mezzanine.dtbo
  • monaco-evk-camera-imx577.dtbo
  • monaco-evk-ifp-mezzanine.dtbo
  • talos-el2.dtbo
  • qcs6490-rb3gen2-industrial-mezzanine.dtbo
  • qcs6490-rb3gen2-vision-mezzanine.dtbo
  • monaco-el2.dtbo
  • lemans-el2.dtbo
  • qrb5165-rb5-vision-mezzanine.dtbo
  • sc7180-el2.dtbo
  • sc8280xp-el2.dtbo
  • sdm845-db845c-navigation-mezzanine.dtbo
  • sm8650-hdk-display-card.dtbo
  • talos-evk-lvds-auo,g133han01.dtbo
  • x1-el2.dtbo

Issues

  • Cannot verify diff faithfulness: Network restrictions prevent fetching upstream patch from lore.kernel.org for byte-by-byte comparison
  • Lore link date anomaly: Link references April 28, 2026, but commit date is April 3, 2026 (commit predates posting by 25 days — unusual but possible if link was added retroactively)

Verdict

Commit message structure and diff pattern are correct. However, cannot confirm diff matches upstream due to network restrictions. Manual verification against lore.kernel.org required.


Commit 2: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays

Upstream commit: N/A (vendor-only)
Verdict: ✅ PASS — Vendor-only commit; no upstream comparison required

Commit Message

Check Status Note
Subject format Proper QCLINUX prefix for vendor-only changes
Body structure Clear description of change and rationale
Link tag present N/A Not expected for QCLINUX commits
Authorship Author: Vishwas Udupa vudupa@qti.qualcomm.com
Signed-off-by present Matches author

Diff Analysis

Aspect Status Notes
File modified arch/arm64/boot/dts/qcom/Makefile
Change count 10 insertions (adds 10 camx .dtbo install targets)
Change pattern Consistent with Commit 1 pattern
Mechanical correctness Each added line follows existing Makefile syntax
Builds on Commit 1 Base index 01cde722562e0 matches Commit 1 output

Camx overlays added (10 total):

  • hamoa-evk-camx.dtbo
  • lemans-evk-camx.dtbo
  • lemans-camx-el2.dtbo
  • monaco-evk-camx.dtbo
  • monaco-camx-el2.dtbo
  • qcs615-ride-camx.dtbo
  • qcs6490-rb3gen2-vision-mezzanine-camx.dtbo
  • qcs8300-ride-camx.dtbo
  • sa8775p-ride-camx.dtbo
  • talos-evk-camx.dtbo

Issues

None. Vendor-only commit is properly formatted and scoped.


Final Summary

Commit 1 (FROMLIST)

  1. Lore link present: Yes — https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
  2. Lore link matches PR commits: Cannot verify — network restrictions prevent fetching upstream patch for comparison
  3. Upstream patch status: Unknown — cannot query lore.kernel.org; link date (2026-04-28) suggests patch was posted upstream
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Commit 2 (QCLINUX)

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Overall Recommendation

⚠️ CONDITIONAL APPROVAL

  • Commit 2 (QCLINUX): ✅ Ready to merge — properly formatted vendor-only commit
  • Commit 1 (FROMLIST): ⚠️ Requires manual verification:
    • Fetch upstream patch from lore.kernel.org when network is available
    • Verify diff matches upstream byte-for-byte (ignoring context line differences)
    • Confirm upstream acceptance status (merged/pending/rejected)
    • Investigate commit date vs. lore posting date discrepancy (commit: 2026-04-03, link: 2026-04-28)

Action items:

  1. Manually verify Commit 1 against https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com/raw
  2. Check if upstream patch has been accepted into mainline or linux-next
  3. If upstream differs, update PR to match upstream exactly
  4. If upstream was rejected or requires changes, update FROMLIST commit accordingly

@qlijarvis

Copy link
Copy Markdown

PR #654 — checker-log-analyzer

PR: #654
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27673281019

Checker Result Summary
Checker Result Summary
checkpatch Both commits pass with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped — no changes in Documentation/devicetree/bindings
dtb-check ⏭️ Skipped — no DTBs built under head (Makefile-only change)
sparse-check ⏭️ Skipped — no C code changes
check-uapi-headers ⏭️ Skipped — no UAPI header changes
check-patch-compliance FAILED — 2 blockers
tag-check N/A Not applicable (not targeting qcom-next/qcom-next-staging)
qcom-next-check FROMLIST prefix present on commit 1

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #654 — Install DT overlays via dtbs_install
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27673281019

Checker Result Summary
checkpatch Both commits pass with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped — no changes in Documentation/devicetree/bindings
dtb-check ⏭️ Skipped — no DTBs built under head (Makefile-only change)
sparse-check ⏭️ Skipped — no C code changes
check-uapi-headers ⏭️ Skipped — no UAPI header changes
check-patch-compliance FAILED — 2 blockers
tag-check N/A Not applicable (not targeting qcom-next/qcom-next-staging)
qcom-next-check FROMLIST prefix present on commit 1

❌ check-patch-compliance

Root cause: Two distinct compliance violations detected by the patch compliance checker

Failure details:

Issue 1 — Commit 1 (733fa0c):

Checking commit: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install
Change is different from the one mentioned in Link

The checker fetched the upstream patch from the lore.kernel.org link (https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com) and found that the diff in the PR does not match the upstream version byte-for-byte. This indicates the FROMLIST commit has been modified from its upstream posting.

Issue 2 — Commit 2 (3565a31):

Checking commit: QCLINUX: arm64: dts: qcom: Install camx DTBO overlays
Commit summary does not start with a required prefix

The second commit uses QCLINUX: prefix, but the checker expects one of the standard prefixes. Based on Qualcomm Linux kernel conventions, vendor-only commits should typically use prefixes like:

  • ANDROID: for Android-specific changes
  • CHROMEOS: for ChromeOS-specific changes
  • Or subsystem-specific prefixes for vendor changes

The QCLINUX: prefix is not recognized as a valid prefix by the compliance checker.

Fix:

For Commit 1:

  1. Verify the upstream patch at the lore link matches your intent
  2. If upstream was updated after initial posting, either:
    • Update the Link tag to point to the correct version (e.g., v2, v3)
    • Or rebase your commit to match the exact upstream diff
  3. If you intentionally modified the upstream patch, this should be a separate vendor commit, not FROMLIST

For Commit 2:
Replace QCLINUX: with an appropriate prefix. Options:

  • If this is Android-specific: ANDROID: arm64: dts: qcom: Install camx DTBO overlays
  • If this is a general vendor addition: Use subsystem prefix like arm64: dts: qcom: Install camx DTBO overlays (no vendor prefix)
  • Check with your team's commit message guidelines for the correct vendor prefix

Reproduce locally:

# Clone kernel-checkers
git clone https://github.com/qualcomm-linux/kernel-checkers.git

# Run check-patch-compliance on your branch
cd kernel-checkers
bash check-patch-compliance.sh --kernel-src /path/to/kernel \
  --base <base-commit> --head <pr-head-commit>

Verdict

2 blockers must be fixed before merge:

  1. Commit 1: FROMLIST diff must exactly match upstream lore posting
  2. Commit 2: Replace QCLINUX: prefix with a recognized vendor/subsystem prefix

@qlijarvis

Copy link
Copy Markdown

PR #654 — validate-patch

PR: #654

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes (commit 1 only) — https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com

  2. Lore link matches PR commits: Cannot verify — Network access restricted; unable to fetch upstream patch for comparison. Date mismatch (commit Apr 3 vs. message-ID Apr 28) raises questions about version alignment.

  3. Upstream patch status: Unknown — Cannot check lore.kernel.org due to network restrictions. The FROMLIST prefix indicates it was posted for review but acceptance status is unverified.

  4. PR present in qcom-next: Not checked — No kernel tree access per constraints.


Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #654
Commits: 2 patches (1 FROMLIST + 1 QCLINUX vendor-only)


Commit 1/2: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install

Upstream commit: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
Verdict: ⚠️ PARTIAL — Cannot verify upstream content (network restricted), date mismatch detected

Commit Message

Check Status Note
Subject format FROMLIST prefix present, subsystem/scope correct
Body structure Problem → Impact → Solution flow clear
Rationale preserved Explains why DTBOs need explicit install targets
Link tag present Lore link included
Link tag placement Link before Signed-off-by (correct order)
Authorship preserved Author: Vishwas Udupa vudupa@qti.qualcomm.com
Signed-off-by present Present and matches author
Fixes tag N/A Not a bugfix, no Fixes tag needed

Diff Analysis

File Status Notes
arch/arm64/boot/dts/qcom/Makefile +18 lines: adds dtb-$(CONFIG_ARCH_QCOM) entries for .dtbo files

Pattern: Each .dtbo file gets its own dtb-$(CONFIG_ARCH_QCOM) += <name>.dtbo line immediately after the corresponding composite .dtb entry. Consistent with Makefile conventions.

Files affected: 18 DTBO overlays across multiple platforms (apq8016, lemans, monaco, qcs615, qcs6490, qcs8300, qcs9100, qrb5165, sc7180, sc8280xp, sdm845, sm8650, talos, x1/x1p).

Issues

  • ⚠️ Date mismatch: Commit date is Fri, 3 Apr 2026 but lore message-ID indicates 20260428 (April 28, 2026). The commit appears to predate the upstream posting by 25 days, which is unusual for a FROMLIST patch.
  • ⚠️ Cannot verify upstream diff: Network access restricted; unable to fetch lore patch to confirm diff faithfulness.

Verdict

Conditional approval — Commit message structure and diff pattern are correct. However, the date discrepancy suggests this may be a forward-ported or rebased version of a patch that was posted upstream later. Recommend verifying:

  1. The lore link actually exists and matches this diff
  2. Whether this is the correct upstream version or if there were revisions

Commit 2/2: QCLINUX: arm64: dts: qcom: add camx dtbo overlays

Upstream commit: N/A (vendor-only)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject format QCLINUX prefix correct for vendor-only
Body structure Clear what/how/why explanation
Rationale Explains dtbs_install integration for distro packages
Link tag N/A Not expected for QCLINUX commits
Authorship Same author as commit 1
Signed-off-by Present

Diff Analysis

File Status Notes
arch/arm64/boot/dts/qcom/Makefile +10 lines: adds dtb-$(CONFIG_ARCH_QCOM) entries for camx .dtbo files

Pattern: Identical to commit 1 — adds explicit install targets for camx-specific DTBO overlays.

Files affected: 10 camx DTBO overlays (hamoa, lemans, monaco, qcs5430, qcs615, qcs6490, qcs8300, sa8775p, talos).

Issues

None detected.

Verdict

Approve — Well-formed vendor commit that extends commit 1's pattern to Qualcomm-specific camx overlays.


Final Summary

  1. Lore link present: Yes (commit 1 only) — https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com

  2. Lore link matches PR commits: Cannot verify — Network access restricted; unable to fetch upstream patch for comparison. Date mismatch (commit Apr 3 vs. message-ID Apr 28) raises questions about version alignment.

  3. Upstream patch status: Unknown — Cannot check lore.kernel.org due to network restrictions. The FROMLIST prefix indicates it was posted for review but acceptance status is unverified.

  4. PR present in qcom-next: Not checked — No kernel tree access per constraints.


Recommendations

Commit 1 (FROMLIST):

  • ⚠️ Action required: Verify the lore link is valid and the diff matches upstream exactly
  • ⚠️ Action required: Explain the date discrepancy (commit dated Apr 3, lore message-ID dated Apr 28)
  • If this is a rebased/updated version, consider whether the message-ID should be updated or if a note should be added

Commit 2 (QCLINUX):

  • ✅ Ready to merge as-is

Overall: The technical content and structure of both commits are sound. The primary concern is verifying commit 1's upstream alignment given the date anomaly and network restrictions preventing direct comparison.

@qlijarvis

Copy link
Copy Markdown

PR #654 — checker-log-analyzer

PR: #654
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27682496698

Checker Result Summary
Checker Result Summary
checkpatch Both commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ⏭️ Skipped - no DTBs built under head
sparse-check ⏭️ Skipped - no C source changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance 2 failures: patch mismatch + invalid prefix
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #654 - arm64: dts: qcom: install DT overlays via dtbs_install
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27682496698

Checker Result Summary
checkpatch Both commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ⏭️ Skipped - no DTBs built under head
sparse-check ⏭️ Skipped - no C source changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance 2 failures: patch mismatch + invalid prefix
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: Two distinct compliance violations detected by the patch compliance checker.

Failure details:

Issue 1 - Commit 733fa0c (FROMLIST patch):

Checking commit: FROMLIST: arm64: dts: qcom: install DT overlays via dtbs_install
Change is different from the one mentioned in Link

The first commit claims to be FROMLIST: and references:

Link: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com

However, the checker detected that the actual patch content differs from what was posted to the mailing list at that Link. This violates the FROMLIST policy which requires patches to match their upstream submission exactly.

Issue 2 - Commit 4dfa321 (QCLINUX patch):

Checking commit: QCLINUX: arm64: dts: qcom: add camx dtbo overlays
Commit summary does not start with a required prefix

The second commit uses QCLINUX: prefix, but this is not a valid prefix for the qcom-6.18.y branch. Valid prefixes for this branch are:

  • UPSTREAM: - for patches already merged in mainline
  • FROMLIST: - for patches posted to mailing lists but not yet merged
  • BACKPORT: - for patches backported from newer kernel versions

Fix:

For Issue 1 (FROMLIST mismatch):

  1. Verify the lore link is correct: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
  2. Either:
    • Update the patch to match exactly what was sent to the mailing list, OR
    • Update the Link: tag to point to the correct version, OR
    • If this is a modified version, change prefix from FROMLIST: to BACKPORT: or another appropriate prefix

For Issue 2 (invalid QCLINUX prefix):

  1. Replace QCLINUX: with a valid prefix:
    • If this is Qualcomm-specific and not going upstream: Remove the prefix entirely or use BACKPORT: if based on an upstream patch
    • If this will be submitted upstream: Use FROMLIST: and add a Link: tag
    • If already merged upstream: Use UPSTREAM: and add a Link: tag

Reproduce locally:

cd /path/to/kernel
git fetch origin pull/654/head:pr-654
git checkout qcom-6.18.y
git merge --no-commit pr-654
git commit -m "Merged PR #654"

# Clone kernel-checkers
git clone https://github.com/qualcomm-linux/kernel-checkers.git

# Run the compliance checker
bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base 360986b713f88d182fb17fdf5decedf665a77834 \
  --head HEAD

Verdict

2 blockers must be fixed before merge:

  1. FROMLIST patch content must match the lore.kernel.org link, or the prefix/link must be corrected
  2. QCLINUX prefix must be replaced with a valid prefix (UPSTREAM/FROMLIST/BACKPORT or removed)

Overlay binaries (.dtbo) are currently only built implicitly as
dependencies of composite firmware images and are therefore absent from the
kernel install output.

Even when final DTBs are produced at build time, some distributions rely on
standalone DTBOs for runtime selection and application by bootloaders or
firmware. Without explicit install targets, DTBOs are not picked up by the
standard dtbs_install flow and therefore cannot be packaged alongside DTBs.

Add explicit dtb-$(CONFIG_ARCH_QCOM) entries for all DT overlays defined in
this Makefile so they are installed via dtbs_install, matching existing
DTB install behaviour.

Link: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com
Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
Install Qualcomm camx DTBO overlay files by adding them
to the dtb-$(CONFIG_ARCH_QCOM) build/install list

This makes DTBOs available through the standard dtbs_install
flow and ensures they are included in distro kernel packages

Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #654 — validate-patch

PR: #654

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

Commit 1/2 (BACKPORT):

  1. Lore link present: Yes - but link dated April 28, 2026 returns empty content
  2. Lore link matches PR commits: Cannot verify - lore link inaccessible
  3. Upstream patch status: Unknown - cannot access lore link to verify if posted/accepted
  4. PR present in qcom-next: Not checked - no kernel tree access per constraints

Commit 2/2 (QCLINUX):

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Recommendation: Before merging, clarify commit 1/2:

  • Verify if patch was actually posted to lore.kernel.org
  • If posted but not accepted, change prefix to FROMLIST:
  • If accepted upstream, add upstream commit SHA to commit message
  • If never posted, consider whether BACKPORT: is appropriate or if this should be FROMLIST: or QCLINUX:
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #654 - Install DT overlays via dtbs_install
Upstream commit: https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com (future date - link not accessible)
Verdict: ⚠️ PARTIAL


Commit 1/2: BACKPORT: arm64: dts: qcom: install DT overlays via dtbs_install

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore link dated April 2026 (future), not accessible
Body preserves rationale Clear explanation of why DTBOs need explicit install targets
Fixes tag present/correct N/A Not a bug fix; feature addition
Authorship preserved Vishwas Udupa vudupa@qti.qualcomm.com
Backport note (if applicable) ⚠️ BACKPORT: prefix present but lore link is inaccessible/future-dated

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds 18 dtb-$(CONFIG_ARCH_QCOM) entries for .dtbo files

Issues

  • Lore link dated in future: Link shows 20260428 (April 28, 2026) but current date is June 18, 2026. The link returns empty content, suggesting either:
    • The patch was never posted to lore
    • The message-ID is incorrect
    • The patch is still in draft/local state
  • BACKPORT prefix without upstream evidence: Using BACKPORT: prefix implies this was accepted upstream, but cannot verify the upstream commit or acceptance status
  • Commit message structure: Link: tag appears before Signed-off-by:, which is correct kernel style

Verdict for Commit 1/2

Cannot verify upstream fidelity. The BACKPORT: prefix suggests this should match an upstream commit, but the lore link is inaccessible. Need to verify if this patch was actually posted/accepted upstream before merging.


Commit 2/2: QCLINUX: arm64: dts: qcom: add camx dtbo overlays

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix indicates vendor-only
Body preserves rationale Clear explanation of camx DTBO installation
Fixes tag present/correct N/A Not a bug fix
Authorship preserved Vishwas Udupa vudupa@qti.qualcomm.com
Backport note (if applicable) N/A Vendor-only change

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds 10 dtb-$(CONFIG_ARCH_QCOM) entries for camx .dtbo files

Issues

None - vendor-only commit follows expected conventions.

Verdict for Commit 2/2

✅ PASS - Properly formatted vendor-only commit with QCLINUX: prefix.


Overall Issues

  1. Commit 1/2 lore link verification failed: The provided lore.kernel.org link dated April 28, 2026 returns no content. This raises concerns:

    • Was this patch actually submitted upstream?
    • Is the message-ID correct?
    • Should this use FROMLIST: instead of BACKPORT:?
  2. BACKPORT vs FROMLIST: If the patch hasn't been accepted upstream yet, it should use FROMLIST: prefix, not BACKPORT:. BACKPORT: implies the patch is already in an upstream tree (mainline, stable, or subsystem maintainer tree).

  3. No upstream commit SHA: A proper BACKPORT should reference the upstream commit SHA in the commit message (e.g., "commit abc123def456 upstream" or similar).


Overall Verdict

⚠️ PARTIAL - Commit 2/2 is acceptable as vendor-only. Commit 1/2 requires clarification:

  • Verify the lore link is correct
  • Confirm upstream acceptance status
  • If not yet accepted, change BACKPORT: to FROMLIST:
  • If accepted, add upstream commit SHA reference

Final Summary

Commit 1/2 (BACKPORT):

  1. Lore link present: Yes - but link dated April 28, 2026 returns empty content
  2. Lore link matches PR commits: Cannot verify - lore link inaccessible
  3. Upstream patch status: Unknown - cannot access lore link to verify if posted/accepted
  4. PR present in qcom-next: Not checked - no kernel tree access per constraints

Commit 2/2 (QCLINUX):

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Recommendation: Before merging, clarify commit 1/2:

  • Verify if patch was actually posted to lore.kernel.org
  • If posted but not accepted, change prefix to FROMLIST:
  • If accepted upstream, add upstream commit SHA to commit message
  • If never posted, consider whether BACKPORT: is appropriate or if this should be FROMLIST: or QCLINUX:

@qlijarvis

Copy link
Copy Markdown

PR #654 — checker-log-analyzer

PR: #654
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27752184114

Checker Result Summary
Checker Result Summary
checkpatch Both commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ⏭️ Skipped - no DTBs built under head
sparse-check ⏭️ Skipped - nothing changed in C source files
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance 2 blockers: BACKPORT patch differs from upstream link; QCLINUX commit missing required prefix
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #654 - arm64: dts: qcom: install DT overlays via dtbs_install
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27752184114

Checker Result Summary
checkpatch Both commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ⏭️ Skipped - no DTBs built under head
sparse-check ⏭️ Skipped - nothing changed in C source files
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance 2 blockers: BACKPORT patch differs from upstream link; QCLINUX commit missing required prefix
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: Two compliance violations detected by the patch compliance checker

Failure details:

Commit 1 (934e5dd): BACKPORT: arm64: dts: qcom: install DT overlays via dtbs_install

Change is different from the one mentioned in Link

The checker compared the patch content against the upstream patch at https://lore.kernel.org/all/20260428123725.3457865-1-vudupa@qti.qualcomm.com and found differences. This indicates the BACKPORT is not a faithful cherry-pick of the upstream commit.

Commit 2 (dd53524): QCLINUX: arm64: dts: qcom: add camx dtbo overlays

Commit summary does not start with a required prefix

The commit uses QCLINUX: prefix, but the checker expects one of the standard prefixes for the qcom-6.18.y branch. Valid prefixes typically include:

  • UPSTREAM: - for commits already merged in mainline
  • FROMLIST: - for commits posted to mailing lists but not yet merged
  • BACKPORT: - for modified backports of upstream commits
  • No prefix - for original downstream-only changes (but subject must follow kernel style)

Fix:

For Commit 1 (BACKPORT):

  1. Verify the upstream patch at the Link URL matches your changes exactly
  2. If the patch differs from upstream, either:
    • Update the patch to match upstream exactly, OR
    • Remove the BACKPORT: prefix and the Link: tag if this is a modified version
  3. If this is truly a backport, ensure you cherry-picked the exact upstream commit without modifications

For Commit 2 (QCLINUX):

  1. Remove the QCLINUX: prefix from the subject line
  2. The subject should be: arm64: dts: qcom: add camx dtbo overlays
  3. Since this appears to be downstream-only work (adding Qualcomm-specific camx overlays), no prefix is needed
  4. Alternatively, if these overlays were posted upstream, use FROMLIST: prefix and add a Link: tag

Reproduce locally:

cd /path/to/kernel
git fetch origin qcom-6.18.y
git checkout qcom-6.18.y
git fetch origin pull/654/head:pr-654
git merge pr-654 --no-commit
git commit -m "Merged PR #654"

# Clone kernel-checkers
cd ..
git clone https://github.com/qualcomm-linux/kernel-checkers.git

# Run the compliance checker
cd kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base origin/qcom-6.18.y \
  --head HEAD

Verdict

2 blockers must be fixed before merge: The BACKPORT commit must either match its upstream Link exactly or be reclassified, and the QCLINUX commit needs its prefix removed or changed to a valid prefix (FROMLIST/UPSTREAM/BACKPORT or none).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants