QCLINUX: arm64: dts: qcom: Add Purwa sensors support by shubammm · Pull Request #662 · qualcomm-linux/kernel

shubammm · 2026-06-05T09:32:46Z

Add og0va1b IR/VGA camera sensor node.
Add imx688 camera sensor node

CRs-Fixed: 4561668

qswat-orbit-external · 2026-06-05T09:32:54Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-06-05T09:49:03Z

Merge Check Failed: CR Not Eligible for Merge

CR 4561668 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561668
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-05T09:54:29Z

Merge Check Failed: CR Not Eligible for Merge

CR 4561668 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561668
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qlijarvis · 2026-06-05T10:07:39Z

PR #662 — validate-patch

PR: #662

Verdict	Issues	Detailed Report
⚠️	3	Full report

Final Summary

Lore link present: No — QCLINUX: prefix; no lore link expected or required
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — vendor-only change, not posted upstream
PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #662 - QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Upstream commit: N/A (vendor-only)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note

Subject matches upstream N/A Vendor-only commit (QCLINUX: prefix)

Body preserves rationale ⚠️ Minimal description; lacks hardware context

Fixes tag present/correct N/A New feature, not a fix

Authorship preserved ✅ Author: shubamm shubamm@qti.qualcomm.com

Backport note (if applicable) N/A Not a backport

Diff

File Status Notes

arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi ✅ New sensor definitions for og0va1b and imx688

arch/arm64/boot/dts/qcom/purwa-evk-camx.dtso ✅ Includes new sensor file

Issues

Commit message clarity: The body mentions "og0va1b IR/VGA camera sensor" but the DT node comment says "cam1-og0a1b" (typo: og0va1b vs og0a1b)

Change-Id present: Gerrit Change-Id tag is included; typically removed for upstream-bound patches, but acceptable for vendor trees

Minimal rationale: Commit body could benefit from brief hardware context (e.g., "Add camera sensor support for Purwa EVK platform")

Verdict

Acceptable for vendor tree merge with minor naming inconsistency between commit message and code comment.

Final Summary

Lore link present: No — QCLINUX: prefix; no lore link expected or required

Lore link matches PR commits: N/A — no lore link to compare against

Upstream patch status: N/A — vendor-only change, not posted upstream

PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

qlijarvis · 2026-06-05T10:07:40Z

PR #662 — checker-log-analyzer

PR: #662
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27007299289

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 error (Change-Id), 3 warnings (undocumented compatibles)
dt-binding-check	✅	No DT binding changes
dtb-check	❌	Duplicate node definitions causing FDT_ERR_NOTFOUND
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Missing required subject prefix (UPSTREAM:/FROMLIST:)
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #662 - QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27007299289

Checker Result Summary

checkpatch ❌ 1 error (Change-Id), 3 warnings (undocumented compatibles)

dt-binding-check ✅ No DT binding changes

dtb-check ❌ Duplicate node definitions causing FDT_ERR_NOTFOUND

sparse-check ⏭️ Skipped (no C code changes)

check-uapi-headers ⏭️ Skipped (no UAPI changes)

check-patch-compliance ❌ Missing required subject prefix (UPSTREAM:/FROMLIST:)

tag-check N/A Not applicable for qcom-6.18.y branch

qcom-next-check N/A Not applicable for qcom-6.18.y branch

❌ checkpatch

Root cause: Gerrit Change-Id present in commit message (line 9) and undocumented DT compatible strings.

Failure details:
ERROR: Remove Gerrit Change-Id's before submitting upstream
#9: 
Change-Id: Ic416292cb290a6287244dcd5a088180b2e290bc9

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#34: FILE: arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:12:
+		compatible = "qcom,cam-sensor";

WARNING: DT compatible string "qcom,cam-res-mgr" appears un-documented -- check ./Documentation/devicetree/bindings/
#108: FILE: arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:86:
+		compatible = "qcom,cam-res-mgr";
Fix:

Remove the Change-Id: Ic416292cb290a6287244dcd5a088180b2e290bc9 line from the commit message

The undocumented compatible warnings are acceptable for vendor-specific downstream patches (QCLINUX prefix indicates this is not for upstream submission)

Reproduce locally:
./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git HEAD~1..HEAD
❌ dtb-check

Root cause: Duplicate node definitions for &cam_cci0 and &cam_cci1 — both purwa-camera.dtsi and the new purwa-camera-sensor.dtsi define child nodes under these references, causing DTC to fail overlay application.

Failure details:
also defined at ../arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:8.11-43.3
also defined at ../arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:45.11-82.3

Failed to apply 'arch/arm64/boot/dts/qcom/purwa-evk-camx.dtbo': FDT_ERR_NOTFOUND
make[4]: *** [../scripts/Makefile.dtbs:85: arch/arm64/boot/dts/qcom/purwa-evk-camx.dtb] Error 1
The error indicates that purwa-camera.dtsi already defines &cam_cci0 and &cam_cci1 nodes (lines 489 and 586), and the new purwa-camera-sensor.dtsi is attempting to define them again (lines 8 and 45). When both files are included in purwa-evk-camx.dtso, the DTC compiler encounters duplicate definitions and fails to apply the overlay.

Fix:
The sensor nodes in purwa-camera-sensor.dtsi should be added as children inside the existing &cam_cci0 and &cam_cci1 references, not as new top-level references. The structure should be:
&cam_cci0 {
    qcom,cam-sensor1 {
        // sensor properties
    };
};
However, if purwa-camera.dtsi already defines the CCI nodes with their own structure, you need to either:

Add the sensor nodes directly to purwa-camera.dtsi instead of creating a separate file, OR

Ensure purwa-camera-sensor.dtsi uses unique child node names that don't conflict with existing definitions

Check what's already defined in purwa-camera.dtsi at lines 489-584 (cam_cci0) and 586-681 (cam_cci1) to understand the existing structure.

Reproduce locally:
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) CHECK_DTBS=y qcom/purwa-evk-camx.dtb
❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix for the qcom-6.18.y branch.

Failure details:
Checking commit: QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Commit summary does not start with a required prefix
Fix:
For patches targeting qcom-6.18.y (a stable/release branch), commits should use one of these prefixes:

UPSTREAM: - if the patch is already merged in mainline Linux

FROMLIST: - if the patch is posted to a mailing list but not yet merged

BACKPORT: - if the patch is a backport with modifications

Since this appears to be a new downstream-only patch (QCLINUX prefix), it may not be appropriate for qcom-6.18.y. Consider:

If this is truly downstream-only, target qcom-next or qcom-next-staging instead

If this is based on an upstream patch, change the prefix to UPSTREAM: or FROMLIST: and include the appropriate Link: tag

Reproduce locally:
# Check if commit follows compliance rules
git log --oneline -1
# Should start with UPSTREAM:, FROMLIST:, or BACKPORT: for stable branches
Verdict

3 blockers must be fixed before merge:

Critical: Remove Gerrit Change-Id from commit message

Critical: Fix duplicate DT node definitions causing dtb-check build failure

Critical: Add appropriate subject prefix (UPSTREAM:/FROMLIST:) or retarget to qcom-next branch

The DT compatible warnings are acceptable for downstream patches but the duplicate node issue will prevent the DTB from building successfully.

qswat-orbit-external · 2026-06-05T11:26:58Z

Merge Check Failed: CR Not Eligible for Merge

CR 4561668 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561668
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

Add og0va1b IR/VGA camera sensor node. Add imx688 camera sensor module node CRs-Fixed: 4561668 Signed-off-by: shubamm <shubamm@qti.qualcomm.com>

qlijarvis · 2026-06-17T12:15:52Z

PR #662 — validate-patch

PR: #662

Verdict	Issues	Detailed Report
✅	0	Full report

Final Summary

Lore link present: No — QCLINUX: prefix; no lore link expected or required
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — vendor-only change, not posted upstream
PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #662 - QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Upstream commit: N/A (vendor-only QCLINUX commit)
Verdict: ✅ PASS

Commit Message

Check Status Note

Subject matches upstream N/A Vendor-only commit with QCLINUX: prefix

Body preserves rationale ✅ Clear description of added sensor nodes

Fixes tag present/correct N/A New feature addition, no Fixes tag needed

Authorship preserved ✅ Author: shubamm shubamm@qti.qualcomm.com

Backport note (if applicable) N/A Not a backport; original vendor work

Diff

File Status Notes

arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi ✅ New file: 89 lines, adds og0va1b and imx688 sensor nodes

arch/arm64/boot/dts/qcom/purwa-evk-camx.dtso ✅ Single line include addition, clean integration

Commit Message Quality

Subject: QCLINUX: arm64: dts: qcom: Add Purwa sensors support

✅ Proper QCLINUX: prefix for vendor-only work

✅ Correct subsystem path (arm64: dts: qcom:)

✅ Imperative mood ("Add" not "Added")

✅ Concise and descriptive

Body:
Add og0va1b IR/VGA camera sensor node.
Add imx688 camera sensor module node
✅ Clear description of what is being added

⚠️ Minor: Second line missing period (inconsistent punctuation)

Trailers:

✅ CRs-Fixed: 4561668 (proper Qualcomm CR reference)

✅ Signed-off-by: present and correct

Technical Content Review

New file: purwa-camera-sensor.dtsi

✅ Proper SPDX license identifier (BSD-3-Clause)

✅ Copyright notice present

✅ Includes required dt-bindings header

✅ Two camera sensor nodes defined:

cam-sensor1 (og0a1b) on CCI0, CSIPHY0

cam-sensor4 (imx688) on CCI1, CSIPHY4

✅ Standard Qualcomm camera sensor properties used

✅ Power domain, regulator, GPIO, clock configuration present

✅ cam-res-mgr node added to soc

Modified file: purwa-evk-camx.dtso

✅ Single include line added after existing camera include

✅ Logical placement in include order

Verdict

Merge as-is. This is a clean vendor-only device tree addition for Purwa platform camera sensors with proper structure, licensing, and commit message formatting.

Final Summary

Lore link present: No — QCLINUX: prefix; no lore link expected or required

Lore link matches PR commits: N/A — no lore link to compare against

Upstream patch status: N/A — vendor-only change, not posted upstream

PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

qlijarvis · 2026-06-17T12:15:54Z

PR #662 — checker-log-analyzer

PR: #662
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27686418766

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	3 warnings: undocumented DT compatible strings
dt-binding-check	✅	No changes in bindings
dtb-check	❌	Duplicate node definitions + FDT_ERR_NOTFOUND
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Invalid subject prefix "QCLINUX:"
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	⏭️	Not applicable for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #662 - QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27686418766

Checker Result Summary

checkpatch ❌ 3 warnings: undocumented DT compatible strings

dt-binding-check ✅ No changes in bindings

dtb-check ❌ Duplicate node definitions + FDT_ERR_NOTFOUND

sparse-check ⏭️ Skipped (no C code changes)

check-uapi-headers ⏭️ Skipped (no UAPI changes)

check-patch-compliance ❌ Invalid subject prefix "QCLINUX:"

tag-check N/A Not applicable for qcom-6.18.y

qcom-next-check ⏭️ Not applicable for qcom-6.18.y

❌ checkpatch

Root cause: Three DT compatible strings used in purwa-camera-sensor.dtsi lack devicetree binding documentation.

Failure details:
WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#34: FILE: arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:12:
+		compatible = "qcom,cam-sensor";

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#70: FILE: arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:48:
+		compatible = "qcom,cam-sensor";

WARNING: DT compatible string "qcom,cam-res-mgr" appears un-documented -- check ./Documentation/devicetree/bindings/
#108: FILE: arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:86:
+		compatible = "qcom,cam-res-mgr";
Fix: Add YAML devicetree binding documentation for these camera subsystem compatibles in Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml and Documentation/devicetree/bindings/media/qcom,cam-res-mgr.yaml, or suppress warnings if these are vendor-specific downstream-only bindings not intended for upstream.

Reproduce locally:
./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 360986b713f88d182fb17fdf5decedf665a77834..HEAD
❌ dtb-check

Root cause: The new purwa-camera-sensor.dtsi defines nodes inside &cam_cci0 and &cam_cci1 that conflict with existing definitions in purwa-camera.dtsi, causing duplicate node warnings and overlay application failure.

Failure details:
../arch/arm64/boot/dts/qcom/purwa-camera.dtsi:519.30-614.4: Warning (avoid_default_addr_size): /fragment@0/__overlay__/qcom,cci0@ac15000: Relying on default #address-cells value
  also defined at ../arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:8.11-43.3

Failed to apply 'arch/arm64/boot/dts/qcom/purwa-evk-camx.dtbo': FDT_ERR_NOTFOUND
make[4]: *** [../scripts/Makefile.dtbs:85: arch/arm64/boot/dts/qcom/purwa-evk-camx.dtb] Error 1
The dtc compiler detects that &cam_cci0 is being extended in both purwa-camera.dtsi (line 519) and the new purwa-camera-sensor.dtsi (line 8), creating conflicting fragment definitions when building the overlay. The FDT_ERR_NOTFOUND indicates the overlay cannot be applied because the base tree structure doesn't match expectations.

Fix:

Ensure purwa-camera-sensor.dtsi only adds child sensor nodes inside the CCI controllers, not redefining the CCI controller nodes themselves

Verify that purwa-camera.dtsi already defines &cam_cci0 and &cam_cci1 as overlay fragments

The sensor nodes should be added as children within the existing CCI fragments, not as new top-level fragments

Check that the include order in purwa-evk-camx.dtso is correct (camera.dtsi before camera-sensor.dtsi)

Reproduce locally:
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) CHECK_DTBS=y qcom/purwa-evk-camx.dtb
❌ check-patch-compliance

Root cause: Commit subject uses invalid prefix "QCLINUX:" which is not in the allowed list for this repository.

Failure details:
Checking commit: QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Commit summary does not start with a required prefix
Fix: Change the subject prefix from QCLINUX: to one of the accepted prefixes. For device tree changes targeting the qcom-6.18.y branch, use:

arm64: dts: qcom: Add Purwa sensors support (no prefix for downstream-only changes), or

FROMLIST: arm64: dts: qcom: Add Purwa sensors support (if this is being submitted to upstream mailing lists), or

UPSTREAM: arm64: dts: qcom: Add Purwa sensors support (if already accepted upstream)

Reproduce locally:
# Check the allowed prefixes in your repo's checker configuration
git log --oneline --grep="arm64: dts: qcom" -10
Verdict

3 blockers must be fixed before merge:

checkpatch warnings - Add DT binding documentation or suppress if vendor-specific

dtb-check failure - Resolve duplicate node definitions causing overlay build failure

check-patch-compliance - Remove invalid "QCLINUX:" prefix from commit subject

The dtb-check failure is the most critical as it indicates the devicetree will not build correctly. Fix the node structure conflict first, then address the documentation and subject prefix issues.

shubammm requested review from a team, aiquny, quic-kaushalk and rrnayak June 5, 2026 09:32

shubammm force-pushed the purwa_dt_2.0 branch from 49fc92e to 16e3a55 Compare June 5, 2026 11:26

shubammm force-pushed the purwa_dt_2.0 branch from 16e3a55 to beafa2e Compare June 17, 2026 11:37

QCLINUX: arm64: dts: qcom: Add Purwa sensors support

4f4c477

Add og0va1b IR/VGA camera sensor node. Add imx688 camera sensor module node CRs-Fixed: 4561668 Signed-off-by: shubamm <shubamm@qti.qualcomm.com>

shubammm force-pushed the purwa_dt_2.0 branch from beafa2e to 4f4c477 Compare June 17, 2026 11:41

Conversation

shubammm commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qswat-orbit-external Bot commented Jun 5, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 5, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 5, 2026

Uh oh!

qlijarvis commented Jun 5, 2026

PR #662 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Final Summary

Uh oh!

qlijarvis commented Jun 5, 2026

PR #662 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ dtb-check

❌ check-patch-compliance

Verdict

Uh oh!

qswat-orbit-external Bot commented Jun 5, 2026

Uh oh!

qlijarvis commented Jun 17, 2026

PR #662 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Commit Message Quality

Technical Content Review

Verdict

Final Summary

Uh oh!

qlijarvis commented Jun 17, 2026

PR #662 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ dtb-check

❌ check-patch-compliance

Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shubammm commented Jun 5, 2026 •

edited

Loading